Version Packages #7214
Version Packages #7214
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis update introduces an optional Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ReactApp
participant thirdwebSDK
User->>ReactApp: Initiate unlink profile (with allowAccountDeletion=true)
ReactApp->>thirdwebSDK: Call useUnlinkProfile/unlinkProfile({ allowAccountDeletion: true })
thirdwebSDK->>thirdwebSDK: Check if profile is the last one
alt Last profile and allowAccountDeletion=true
thirdwebSDK->>thirdwebSDK: Delete entire account
else Not last profile or allowAccountDeletion=false
thirdwebSDK->>thirdwebSDK: Unlink profile only
end
thirdwebSDK-->>ReactApp: Return result
ReactApp-->>User: Show confirmation/status
Possibly related PRs
Suggested labels
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/wagmi-adapter/CHANGELOG.md (1)
3-3: Add context to the new version entry
The## 0.2.87header is in place but lacks details. Even if there are no adapter-specific changes, consider adding a short note (e.g., “chore: release 0.2.87 to match core SDK update”) or referencing the core feature inthirdweb@5.102.1for better traceability.packages/thirdweb/CHANGELOG.md (1)
7-10: Nit: Align list item indentation
The patch entry and its description should be indented consistently to improve readability under the Markdown list. Consider using four spaces for the continuation line.- - [#7211](https://github.com/thirdweb-dev/js/pull/7211) [`31c4bb2`](https://github.com/thirdweb-dev/js/commit/31c4bb22fc4b9fb5e99824f31ccb25427aaa409e) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - **Add account deletion support when unlinking profiles** - - Added optional `allowAccountDeletion` parameter to `useUnlinkProfile` hook and `unlinkProfile` function. When set to `true`, this allows deleting the entire account when unlinking the last profile associated with it. + - [#7211](https://github.com/thirdweb-dev/js/pull/7211) [`31c4bb2`](https://github.com/thirdweb-dev/js/commit/31c4bb22fc4b9fb5e99824f31ccb25427aaa409e) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - **Add account deletion support when unlinking profiles** + + Added optional `allowAccountDeletion` parameter to `useUnlinkProfile` hook and `unlinkProfile` function. When set to `true`, this allows deleting the entire account when unlinking the last profile associated with it.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.changeset/account-deletion-unlink.md(0 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/account-deletion-unlink.md
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Unit Tests
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (5)
packages/wagmi-adapter/package.json (1)
3-3: Version bump to 0.2.87
Theversionfield has been correctly updated to align with the automated release. The existing peer dependency onthirdweb(^5.85.0) already covers the new5.102.1core SDK patch, so no further changes are needed here.packages/thirdweb/package.json (1)
3-3: Patch version bump looks good.
Updating the version to5.102.1correctly reflects the newallowAccountDeletionfeature in theuseUnlinkProfilehook andunlinkProfilefunction.packages/thirdweb/CHANGELOG.md (3)
11-25: Examples look accurate — React hook usage is clear
Thetsxcode fence and the hook invocation withallowAccountDeletion: trueare correct and aligned with the new API.
3-4:✅ Verification successful
Verify version bump matches package.json
Please ensure that the new## 5.102.1heading aligns with the actual version inpackages/thirdweb/package.json.
🏁 Script executed:
#!/bin/bash # Check that the package.json version has been updated to 5.102.1 rg '"version"\s*:\s*"5\.102\.1"' packages/thirdweb/package.jsonLength of output: 89
✅ Confirmed version bump to 5.102.1
CHANGELOG.mdentry (## 5.102.1) matchespackages/thirdweb/package.json("version": "5.102.1").No further action needed.
27-37:✅ Verification successful
Confirm the direct function import path
Double-check thatimport { unlinkProfile } from "thirdweb/wallets/in-app";is the correct path for the standalone function—this may differ based on package exports or index files.
🏁 Script executed:
#!/bin/bash # Verify that the in-app unlinkProfile export exists at the expected path rg '^export .*unlinkProfile' -A2 packages/thirdweb/wallets/in-app.tsLength of output: 146
🏁 Script executed:
#!/bin/bash # Search for unlinkProfile definition or export across the repo rg --ignore-case 'unlinkProfile' -nR .Length of output: 443
🏁 Script executed:
#!/bin/bash # Correctly search for unlinkProfile definition or usage across the repo rg -n 'unlinkProfile' .Length of output: 6409
🏁 Script executed:
#!/bin/bash # Inspect the subpath exports in package.json to verify if "./wallets/in-app" is supported rg -n '"exports"' -A20 packages/thirdweb/package.jsonLength of output: 828
🏁 Script executed:
#!/bin/bash # Check if the package exports include the wallets subpath for in-app rg -n '"\./wallets' -A5 packages/thirdweb/package.jsonLength of output: 841
Direct import path confirmed
TheunlinkProfilefunction is correctly exported from thethirdweb/wallets/in-appsubpath:
- packages/thirdweb/package.json defines an
"./wallets/in-app"export (lines 105–110).- packages/thirdweb/src/exports/wallets/in-app.ts includes
unlinkProfilein its export list.No changes needed.
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7214 +/- ##
=======================================
Coverage 55.63% 55.63%
=======================================
Files 908 908
Lines 58546 58546
Branches 4128 4127 -1
=======================================
Hits 32572 32572
Misses 25868 25868
Partials 106 106
🚀 New features to boost your workflow:
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
thirdweb@5.102.1
Patch Changes
#7211
31c4bb2Thanks @joaquim-verges! - Add account deletion support when unlinking profilesAdded optional
allowAccountDeletionparameter touseUnlinkProfilehook andunlinkProfilefunction. When set totrue, this allows deleting the entire account when unlinking the last profile associated with it.React Hook Example:
Direct Function Example:
@thirdweb-dev/wagmi-adapter@0.2.87
PR-Codex overview
This PR focuses on updating the version numbers for the
thirdweband@thirdweb-dev/wagmi-adapterpackages and introduces new functionality for account deletion support when unlinking profiles.Detailed summary
versioninpackages/thirdweb/package.jsonfrom5.102.0to5.102.1.versioninpackages/wagmi-adapter/package.jsonfrom0.2.86to0.2.87.packages/thirdweb/CHANGELOG.mdfor version5.102.1.unlinkProfilefunction anduseUnlinkProfilehook.allowAccountDeletionparameter to enable account deletion when unlinking the last profile.Summary by CodeRabbit