[thirdweb] Fix webhook transaction schema parsing #7221
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: b891c84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedThe pull request is closed. WalkthroughA new changeset file was added to document a patch update for the "thirdweb" package, specifically addressing a fix related to webhook parsing. No source code or exported/public entity changes are present; only the changeset documentation was introduced. Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.changeset/calm-pets-post.md (1)
1-6: Consider more descriptive changeset message for schema breaking change.While the changeset format is correct, the description "fix webhook parsing" could be more specific about the nature of the change. Consider a more detailed description that indicates this modifies the webhook payload structure.
--- "thirdweb": patch --- -fix webhook parsing +fix webhook parsing: update transactions schema from array of hashes to array of objects with chainId and transactionHash
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.changeset/calm-pets-post.md(1 hunks)packages/thirdweb/src/bridge/Webhook.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
jnsdls
force-pushed
the
_thirdweb_Fix_webhook_transaction_schema_parsing
branch
from
2fb7939 to
8d115d2
Compare
size-limit report 📦
|
jnsdls
force-pushed
the
_thirdweb_Fix_webhook_transaction_schema_parsing
branch
from
8d115d2 to
b891c84
Compare
Fix Webhook Parsing
This PR updates the webhook schema to correctly parse transaction data. The
transactionsfield in the webhook schema now expects an array of objects withchainIdandtransactionHashproperties, rather than an array of hex strings.Summary by CodeRabbit
PR-Codex overview
This PR focuses on fixing the webhook parsing in the
thirdwebpackage.Detailed summary
thirdwebpackage with a patch to address issues in webhook parsing.