1.38.2 Release - Master (#845)

* 1.38.1-0.0.1 : [update] - walletlink version to 2.5.0 (#835)

* 1.38.1-0.0.2 : [chore] - change xdefi redirect link to chrome store (#833)

* 1.38.1-0.0.3: [fix] Detected wallet logic

* 1.38.1-0.0.4 : [fix] - 1inch wallet (#843)

Author: Adamj1232

.gitignore

@@ -4,4 +4,5 @@ dist/
 package-lock.json
 .rpt2_cache
 .vscode
-*.patch
+*.patch
+.history/

package.json

@@ -1,6 +1,6 @@
 {
   "name": "bnc-onboard",
-  "version": "1.38.1",
+  "version": "1.38.2",
   "description": "Onboard users to web3 by allowing them to select a wallet, get that wallet ready to transact and have access to synced wallet state.",
   "keywords": [
     "ethereum",
@@ -82,7 +82,7 @@
     "hdkey": "^2.0.1",
     "regenerator-runtime": "^0.13.7",
     "trezor-connect": "^8.1.9",
-    "walletlink": "^2.4.7",
+    "walletlink": "^2.5.0",
     "web3-provider-engine": "^15.0.4"
   },
   "resolutions": {

src/modules/select/index.ts

@@ -83,7 +83,7 @@ function select(
       // This wallet is built into onboard so add the walletName and
       // the code below will load it as a wallet module
       wallets.unshift({ walletName: detectedWalletName })
-    } else if (!detectedWalletName && detectedProviderName) {
+    } else if (window?.ethereum && !detectedWalletName) {
       // A provider has been detected but there is not a walletName therefore
       // this wallet is not built into onboard so add it as a generic injected wallet
       wallets.unshift({ walletName: 'detectedwallet' })
@@ -132,7 +132,7 @@ function select(
   if (detectedWalletName && !defaultWalletNames.includes(detectedWalletName)) {
     defaultWalletNames.unshift(detectedWalletName)
     // If we detected a provider but it is not builtin add the generic injected provider
-  } else if (!detectedWalletName && detectedProviderName) {
+  } else if (window?.ethereum && !detectedWalletName) {
     defaultWalletNames.unshift('detectedwallet')
   }
   return Promise.all(

src/modules/select/wallets/1inch.ts

@@ -16,7 +16,8 @@ function oneInchWallet(options: CommonWalletOptions): WalletModule {
       const { createModernProviderInterface, getProviderName } = helpers
       const windowAsAny = window as any
       const provider =
-        windowAsAny || (windowAsAny.web3 && windowAsAny.web3.currentProvider)
+        windowAsAny.ethereum ||
+        (windowAsAny.web3 && windowAsAny.web3.currentProvider)
 
       return {
         provider,

src/modules/select/wallets/xdefi.ts

@@ -28,7 +28,7 @@ function xdefi(options: CommonWalletOptions): WalletModule {
       }
     },
     type: 'injected',
-    link: 'https://www.xdefi.io/',
+    link: 'https://chrome.google.com/webstore/detail/xdefi-wallet/hmeobnfnfcmdkdcmlblgagmfpfboieaf',
     installMessage: extensionInstallMessage,
     desktop: true,
     mobile: true,

src/utilities.ts

@@ -369,10 +369,6 @@ export function getProviderName(provider: any): string | undefined {
     return '1inch'
   }
 
-  if (provider.isOneInchIOSWallet) {
-    return '1inch'
-  }
-
   // =====================================
   // When adding new wallet place above this metamask check as some providers
   // have an isMetaMask property in addition to the wallet's own `is[WalletName]`

yarn.lock

@@ -9488,10 +9488,10 @@ vm-browserify@^1.0.1:
   resolved "https://registry.yarnpkg.com/vm-browserify/-/vm-browserify-1.1.2.tgz#78641c488b8e6ca91a75f511e7a3b32a86e5dda0"
   integrity sha512-2ham8XPWTONajOR0ohOKOHXkm3+gaBmGut3SRuu75xLd/RRaY6vqgh8NBYYk7+RW3u5AtzPQZG8F10LHkl0lAQ==
 
-walletlink@^2.4.7:
-  version "2.4.7"
-  resolved "https://registry.yarnpkg.com/walletlink/-/walletlink-2.4.7.tgz#3dd034f7cd6e9d9f4cc1d677bb951869dc743e20"
-  integrity sha512-jhLVOMly9oWiSE8mZ4/+uMyVsAKHw71kGbgC1xYp50SQpuLT2pfa6Hiw2VQ0omP/WHsDAPFuBo8hJGxggr768w==
+walletlink@^2.5.0:
+  version "2.5.0"
+  resolved "https://registry.yarnpkg.com/walletlink/-/walletlink-2.5.0.tgz#b8db10f4d9f124084feb16d1e2b2d08ba8c20d21"
+  integrity sha512-PBJmK5tZmonwKPABBI2/optaZ11O4kKmkmnU5eLKhk4XRlal5qJ1igZ4U5j3w6w8wxxdhCWpLMHzGWt3n/p7mw==
   dependencies:
     "@metamask/safe-event-emitter" "2.0.0"
     bind-decorator "^1.0.11"