Skip to content

Commit 76a3823

Browse files
Update mm sdk (#2192)
* feat: sdk update * feat: package version update and lockfile * Delete packages/metamask/yarn.lock * Update packages/metamask/package.json * Bump mm package versions in demo and docs * feat: sdk 0.18.5 * feat: update mm sdk to 0.20.3 * Prettier and test * feat: remove unused variables --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
1 parent 4c4056c commit 76a3823

File tree

5 files changed

+26
-30
lines changed

5 files changed

+26
-30
lines changed

docs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
"@web3-onboard/keystone": "^2.3.7",
7373
"@web3-onboard/ledger": "^2.6.0",
7474
"@web3-onboard/magic": "^2.1.7",
75-
"@web3-onboard/metamask": "^2.0.6",
75+
"@web3-onboard/metamask": "^2.0.7-alpha.1",
7676
"@web3-onboard/mew-wallet": "^2.0.4",
7777
"@web3-onboard/phantom": "^2.0.3",
7878
"@web3-onboard/portis": "^2.1.7",

packages/demo/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
"@web3-onboard/keystone": "^2.3.8",
4848
"@web3-onboard/ledger": "^2.6.0",
4949
"@web3-onboard/magic": "^2.1.6",
50-
"@web3-onboard/metamask": "^2.0.6",
50+
"@web3-onboard/metamask": "^2.0.7-alpha.1",
5151
"@web3-onboard/mew-wallet": "^2.0.3",
5252
"@web3-onboard/phantom": "^2.0.3",
5353
"@web3-onboard/portis": "^2.1.6",

packages/metamask/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@web3-onboard/metamask",
3-
"version": "2.0.6",
3+
"version": "2.0.7-alpha-1",
44
"description": "MetaMask SDK wallet module for connecting to Web3-Onboard. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
55
"keywords": [
66
"Ethereum",
@@ -60,7 +60,7 @@
6060
"typescript": "^5.2.2"
6161
},
6262
"dependencies": {
63-
"@metamask/sdk": "^0.18.6",
63+
"@metamask/sdk": "^0.20.3",
6464
"@web3-onboard/common": "^2.3.3"
6565
},
6666
"engines": {

packages/metamask/src/index.ts

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ function metamask({
4242
label: 'MetaMask',
4343
getIcon: async () => (await import('./icon.js')).default,
4444
getInterface: async ({ appMetadata }) => {
45-
sdk = (window as any).mmsdk || sdk; // Prevent conflict with existing mmsdk instances
45+
sdk = (window as any).mmsdk || sdk // Prevent conflict with existing mmsdk instances
4646

4747
if (sdk) {
4848
// Prevent re-initializing instance as it causes issues with MetaMask sdk mobile provider.
@@ -57,14 +57,11 @@ function metamask({
5757
const appLogoUrl = `data:image/svg+xml;base64,${base64}`
5858
const imports = await importPromise
5959

60-
if (
61-
!imports?.MetaMaskSDKConstructor ||
62-
!imports?.createEIP1193Provider
63-
) {
60+
if (!imports?.MetaMaskSDKConstructor) {
6461
throw new Error('Error importing and initializing MetaMask SDK')
6562
}
6663

67-
const { createEIP1193Provider, MetaMaskSDKConstructor } = imports
64+
const { MetaMaskSDKConstructor } = imports
6865

6966
sdk = new MetaMaskSDKConstructor({
7067
...options,
@@ -76,13 +73,12 @@ function metamask({
7673
_source: 'web3-onboard'
7774
})
7875

79-
await sdk.init();
80-
const provider = sdk.getProvider();
76+
await sdk.init()
77+
const provider = sdk.getProvider()
8178

82-
const _disconnect = sdk.disconnect
83-
if(provider) {
84-
(provider as any).disconnect = () => {
85-
sdk?.terminate();
79+
if (provider) {
80+
;(provider as any).disconnect = () => {
81+
sdk?.terminate()
8682
}
8783
}
8884

yarn.lock

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2363,10 +2363,10 @@
23632363
utf-8-validate "^6.0.3"
23642364
uuid "^8.3.2"
23652365

2366-
"@metamask/sdk-communication-layer@0.18.5":
2367-
version "0.18.5"
2368-
resolved "https://registry.yarnpkg.com/@metamask/sdk-communication-layer/-/sdk-communication-layer-0.18.5.tgz#4d153512172e6d0ff940f8ff6c50c2796ba49ceb"
2369-
integrity sha512-WMf9oJa3rAimjCXMAaaRVFPD0Q6dfZR0r9037KCpD5g9SlVh+TeMISfdQCEKAyhXP3d4CGxmp/Kib8C3mn2YLw==
2366+
"@metamask/sdk-communication-layer@0.20.2":
2367+
version "0.20.2"
2368+
resolved "https://registry.yarnpkg.com/@metamask/sdk-communication-layer/-/sdk-communication-layer-0.20.2.tgz#7f7fd334b2d26abd1a5a1ec1ffadf823a9589344"
2369+
integrity sha512-TN+whYbCClFSkx52Ild1RcjoRyz8YZgwNvZeooIcZIvCfBM6U9W5273KGiY7WLc/oO4KKmFk17d7vMO4gNvhhw==
23702370
dependencies:
23712371
bufferutil "^4.0.8"
23722372
date-fns "^2.29.3"
@@ -2387,10 +2387,10 @@
23872387
react-dom "^18.2.0"
23882388
react-i18next "^13.2.2"
23892389

2390-
"@metamask/sdk-install-modal-web@0.18.5":
2391-
version "0.18.5"
2392-
resolved "https://registry.yarnpkg.com/@metamask/sdk-install-modal-web/-/sdk-install-modal-web-0.18.5.tgz#f074f0c9a9c4d7272004ebf9792ce816418f13e0"
2393-
integrity sha512-Wygc0dgr1PwIA/Sg9WW9QWAsQr4G2GV6iveXt2xw8VKW/9cRORWqYukH1NZLr71hBKzi9AKYBU54Tk5Dfg41zg==
2390+
"@metamask/sdk-install-modal-web@0.20.2":
2391+
version "0.20.2"
2392+
resolved "https://registry.yarnpkg.com/@metamask/sdk-install-modal-web/-/sdk-install-modal-web-0.20.2.tgz#1cf0eb3c26291de7598190878fa9a893c4eb2d66"
2393+
integrity sha512-0QiaZhV15AGdN1zU2jfTI32eC3YkwEpzDfR9+oiZ9bd2G72c6lYBhTsmDGUd01aP6A+bqJR5PjI8Wh2AWtoLeA==
23942394
dependencies:
23952395
qr-code-styling "^1.6.0-rc.1"
23962396

@@ -2425,15 +2425,15 @@
24252425
util "^0.12.4"
24262426
uuid "^8.3.2"
24272427

2428-
"@metamask/sdk@^0.18.6":
2429-
version "0.18.6"
2430-
resolved "https://registry.yarnpkg.com/@metamask/sdk/-/sdk-0.18.6.tgz#ac6cfb80d35b179ee6efd9b2b2f6b67e27422e0a"
2431-
integrity sha512-ZT8e4BrcWrm44apLb412WR0fDsgeaS8UlI1c0wKRUPu1w/UntpXuUVO+EaY8WDlnOPAiAsjyqWKey64/DfvbXQ==
2428+
"@metamask/sdk@^0.20.3":
2429+
version "0.20.3"
2430+
resolved "https://registry.yarnpkg.com/@metamask/sdk/-/sdk-0.20.3.tgz#73851d68ffe5d45c1872c024182922530b187b7a"
2431+
integrity sha512-HZ9NwA+LxiXzuy0YWbWsuD4xejQtp85bhcCAf8UgpA/0dOyF3RS4dKDdBBXSyRgk3RWPjeJgHxioaH4CmBmiRA==
24322432
dependencies:
24332433
"@metamask/onboarding" "^1.0.1"
24342434
"@metamask/providers" "^15.0.0"
2435-
"@metamask/sdk-communication-layer" "0.18.5"
2436-
"@metamask/sdk-install-modal-web" "0.18.5"
2435+
"@metamask/sdk-communication-layer" "0.20.2"
2436+
"@metamask/sdk-install-modal-web" "0.20.2"
24372437
"@types/dom-screen-wake-lock" "^1.0.0"
24382438
bowser "^2.9.0"
24392439
cross-fetch "^4.0.0"

0 commit comments

Comments
 (0)