Remove txn notification support as it relied on legacy BN systems that have been deprecated - cutsom notifications are still available. Update docs

Author: Adamj1232

README.md

@@ -8,7 +8,6 @@
 - **Multiple Wallets and Accounts Connection**: Allow your users to connect multiple wallets and multiple accounts within each wallet at the same time to your app.
 - **Multiple Chain Support**: Allow users to switch between chains/networks with ease.
 - **Account Center**: A persistent interface to manage wallet connections and networks, with a minimal version for mobile
-- **Notify**: Real-time transaction notifications for the connected wallet addresses for all transaction states
 - **Wallet Provider Standardization**: All wallet modules expose a provider that is patched to be compliant with the [EIP-1193](https://eips.ethereum.org/EIPS/eip-1193), [EIP-1102](https://eips.ethereum.org/EIPS/eip-1102), [EIP-3085](https://eips.ethereum.org/EIPS/eip-3085) and [EIP-3326](https://ethereum-magicians.org/t/eip-3326-wallet-switchethereumchain/5471) specifications.
 - **Dynamic Imports**: Supporting multiple wallets in your app requires a lot of dependencies. Onboard dynamically imports a wallet and its dependencies only when the user selects it, so that minimal bandwidth is used.
 

docs/src/lib/components/FeaturesSection.svelte

@@ -7,7 +7,6 @@
   import FeatureCard from './FeatureCard.svelte'
 
   import FrameworksGraphic from './svg/frameworks-group.svelte'
-  import NotifyGraphic from './svg/notify-group.svelte'
   import NetworksGraphic from './svg/networks-graphic.svg'
   import AccountCenterGraphic from './svg/account-center-graphic.svg'
   import WalletsGraphic from './svg/wallet-row.svg'
@@ -89,52 +88,6 @@
       style="margin: 0 auto; max-width: none;"
     />
   </ScrollContainer>
-  <Container>
-    <div class="flexbox">
-      <div>
-        <img
-          src={TransactionPreviewGraphic}
-          alt="Transaction Preview"
-          style="margin: 0 auto; max-width: none;"
-        />
-      </div>
-      <div>
-        <TextBlock
-          title={'Transaction Preview'}
-          subtitle={'Preview transactions to see net-balance changes and gas spent'}
-          text={'Reduce transaction anxiety by allowing users to easily preview expected net-balance changes for their connected wallets before authorizing transactions.'}
-        >
-          <Flexbox --wrap="wrap">
-            <Button href="/docs/modules/transaction-preview" buttonStyle={'link'}
-              >{'Learn More'}</Button
-            >
-            <Button
-              href="/docs/modules/transaction-preview#try-transaction-preview"
-              buttonStyle={'link'}>{'View Demo'}</Button
-            >
-          </Flexbox>
-          <div class="prose">
-            <slot name="installTp" />
-          </div>
-        </TextBlock>
-      </div>
-    </div>
-  </Container>
-  <Container>
-    <div class="flexbox">
-      <TextBlock
-        title={'Real-time transaction notifications'}
-        subtitle={''}
-        text={'Real-time transaction notifications for all connected wallet addresses and all transaction states.'}
-      >
-        <Flexbox --wrap="wrap">
-          <Button href="/docs" buttonStyle={'link'}>{'Learn More'}</Button>
-          <Button href="/examples/connect-wallet" buttonStyle={'link'}>{'View Demo'}</Button>
-        </Flexbox>
-      </TextBlock>
-      <div><NotifyGraphic /></div>
-    </div>
-  </Container>
   <Container>
     <div class="flexbox">
       <div><img src={AccountCenterGraphic} alt="" /></div>

docs/src/routes/docs/[...1]overview/[...1]introduction/+page.md

@@ -30,8 +30,6 @@ Web3 Onboard is the quickest and easiest way to add multi-wallet and multi-chain
 
 - **Framework Agnostic:** Avoid framework lock in -- Web3 Onboard works with any framework and includes helper packages for vue & react.
 
-- **Notify:** Real-time transaction notifications for all transaction states for the connected wallet address(es). In-notification speedups & cancels for hardware wallet connections.
-
 ### Natively Supported EVM Chains
 
 Web3 Onboard supports all EVM networks. Supporting a new network is simply a matter of adding its details in the Chains section upon initialization. For more information see [initialization options](../../modules/core.md#initialization).

docs/src/routes/docs/[...1]overview/[...3]onboard.js-migration-guide/+page.md

@@ -30,7 +30,7 @@ This change allows us to support many web3 wallets without affecting the overall
 
 ### Expansive Initialization Options
 
-We’ve made initialization simpler while introducing more powerful options like [Account Center](https://www.blocknative.com/blog/multichain-and-multiwallet-account-management-on-your-dapp-with-account-center) and Notify in Web3 Onboard.
+We’ve made initialization simpler while introducing more powerful options like [Account Center](https://www.blocknative.com/blog/multichain-and-multiwallet-account-management-on-your-dapp-with-account-center) in Web3 Onboard.
 Web3 Onboard now requires two compulsory initial setup options: `wallets` (Wallet modules, as shown above, to be initialized and added to wallet selection modal) and `chains` (EVM networks your app should work with). You can also pass multiple wallets and chains.
 
 ```

docs/src/routes/docs/[...3]modules/[...1]core/+page.md

@@ -534,22 +534,17 @@ type ContainerElements = {
 
 #### notify
 
-Notify is a feature that provides transaction notifications for all connected wallets on the current blockchain. This document will provide you with an overview of Notify and guide you through the process of integrating it into your decentralized application (dapp).
+Notify is a feature that provides DApps with the ability to send custom messages to the client. This document will provide you with an overview of Notify and guide you through the process of integrating it into your decentralized application (dapp). Check out the [customNotifications API docs for examples and code snippets](#customnotification). 
 
 <img src="{notifyImg}" alt="Transaction notifications image"/>
 
-To enable transaction notifications and updates simply add your Blocknative `apiKey`([sign up for free](https://explorer.blocknative.com/account)) to the web3-onboard configurations as the value to the `apiKey` prop and thats it!
-Transaction notifications will be shown for all transactions occurring on supported chains for all of the users connected wallets.
-When switching chains, the previous chain listeners remain active for 60 seconds to allow the capture and report of any remaining transactions that may be in flight.
-
 Notifications are by default positioned in the same location as the Account Center (if enabled) or can be positioned separately using the `position` property.
 
 ##### **Notify Configuration**
 
 | Property             | Type            | Description                                                   |
 | -------------------- | --------------- | ------------------------------------------------------------- |
 | `enabled`            | boolean         | Indicates whether transaction notifications will be displayed |
-| `transactionHandler` | function        | Optional callback for customizations of notifications         |
 | `position`           | CommonPositions | Position of the notification on the screen                    |
 
 ##### **Position Options**
@@ -561,10 +556,6 @@ Notifications are by default positioned in the same location as the Account Cent
 
 Both `desktop` and `mobile` configurations are of type `Notify`.
 
-###### **Transaction Handler**
-
-The `transactionHandler` is a callback that receives an object of type `EthereumTransactionData`. Based on the data received, the handler can return a custom `Notification` object or a boolean value (false to disable the notification for the current event or undefined for a default notification).
-
 ##### **Customizing Notification**
 
 | Property      | Type     | Description                                                 |
@@ -580,24 +571,6 @@ The `transactionHandler` is a callback that receives an object of type `Ethereum
 
 Notify automatically will match the [`theme`](#theme) defined in the web3-onboard configuration. It can also be styled using the [exposed css variables provided below](#custom-styling). These variables allow for maximum customization with base styling variables setting the global theme (e.g., `--onboard-grey-600`) and more precise component-level styling variables available (`--notify-onboard-grey-600`). The latter takes precedence if defined.
 
-##### **Handling Notifications**
-
-If notifications are enabled, they can be fielded and handled through the onboard app state as seen in the example below - although this is not required for notifications to display:
-
-```javascript
-const wallets = onboard.state.select('notifications')
-const { unsubscribe } = wallets.subscribe((update) =>
-  console.log('transaction notifications: ', update)
-)
-
-// unsubscribe when updates are no longer needed
-unsubscribe()
-```
-
-##### **Notifications as Toast Messages**
-
-The Notifications messages can also be used to send fully customized dapp toast messages and updated. Check out the [customNotifications API docs for examples and code snippets](#customnotification)
-
 ```ts
 type NotifyOptions = {
   desktop: Notify
@@ -1210,74 +1183,6 @@ The `customNotification` method also returns a `dismiss` method that is called w
 
 ---
 
-#### **preflightNotifications**
-
-Notify can be used to deliver standard notifications along with preflight updates by passing a `PreflightNotificationsOptions` object to the `preflightNotifications` API action.
-
-<img src="{notifyPreflightImg}" alt="Preflight notifications image"/>
-
-Preflight event types include:
-
-- `txRequest` : Alert user that there is a transaction request awaiting confirmation by their wallet
-- `txAwaitingApproval` : A previous transaction is awaiting confirmation
-- `txConfirmReminder` : Reminder to confirm a transaction to continue - configurable with the `txApproveReminderTimeout` property; defaults to 15 seconds
-- `nsfFail` : The user has insufficient funds for transaction (requires `gasPrice`, `estimateGas`, `balance`, `txDetails.value`)
-- `txError` : General transaction error (requires `sendTransaction`)
-- `txSendFail` : The user rejected the transaction (requires `sendTransaction`)
-- `txUnderpriced` : The gas price for the transaction is too low (requires `sendTransaction`)
-
-This API call will return a promise that resolves to the transaction hash (if `sendTransaction` resolves the transaction hash and is successful), the internal notification id (if no `sendTransaction` function is provided) or return nothing if an error occurs or `sendTransaction` is not provided or doesn't resolve to a string.
-
-Example:
-
-```typescript copy
-const balanceValue = Object.values(balance)[0]
-// if using ethers v6 this is:
-// ethersProvider = new ethers.BrowserProvider(wallet.provider, 'any')
-const ethersProvider = new ethers.providers.Web3Provider(provider, 'any')
-
-const signer = ethersProvider.getSigner()
-const txDetails = {
-  to: toAddress,
-  value: 100000000000000
-}
-
-const sendTransaction = () => {
-  return signer.sendTransaction(txDetails).then((tx) => tx.hash)
-}
-
-const gasPrice = () => ethersProvider.getGasPrice().then((res) => res.toString())
-
-const estimateGas = () => {
-  return ethersProvider.estimateGas(txDetails).then((res) => res.toString())
-}
-const transactionHash = await onboard.state.actions.preflightNotifications({
-  sendTransaction,
-  gasPrice,
-  estimateGas,
-  balance: balanceValue,
-  txDetails: txDetails
-})
-console.log(transactionHash)
-```
-
-```typescript
-interface PreflightNotificationsOptions {
-  sendTransaction?: () => Promise<string | void>
-  estimateGas?: () => Promise<string>
-  gasPrice?: () => Promise<string>
-  balance?: string | number
-  txDetails?: {
-    value: string | number
-    to?: string
-    from?: string
-  }
-  txApproveReminderTimeout?: number // defaults to 15 seconds if not specified
-}
-```
-
----
-
 #### **updateAccountCenter**
 
 If you need to update your Account Center configuration after initialization, you can call the `updateAccountCenter` function with the new configuration

docs/src/routes/docs/[...3]modules/[...3]react/+page.md

@@ -303,7 +303,6 @@ async function signMessage(chainId) {
 ## useNotifications
 
 This hook allows the dev to access all notifications if enabled, send custom notifications, and update notify <enable/disable & update transactionHandler function>
-**note** This requires an API key be added to the initialization, enabled by default if an API key exists
 For full Notification documentation please see [Notify section within the `@web3-onboard/core` docs](../../modules/core.md#initialization)
 
 ```typescript
@@ -314,7 +313,6 @@ type UseNotifications = (): [
     update: UpdateNotification
   },
   (update: Partial<Notify>) => void,
-  (options: PreflightNotificationsOptions) => Promise<void | string>
 ]
 
 type Notification = {
@@ -368,20 +366,6 @@ type Notify = {
    */
   position?: NotificationPosition
 }
-
-type PreflightNotificationsOptions = {
-  sendTransaction?: () => Promise<string | void>
-  estimateGas?: () => Promise<string>
-  gasPrice?: () => Promise<string>
-  balance?: string | number
-  txDetails?: TxDetails
-  txApproveReminderTimeout?: number
-}
-type TxDetails = {
-  value: string | number
-  to?: string
-  from?: string
-}
 ```
 
 ```typescript