Skip to content

Commit 96aba9e

Browse files
Merge pull request #588 from blocknative/release/1.28.0
Release: 1.28.0
2 parents dedb0fb + aa1f8bb commit 96aba9e

19 files changed

+3104
-1675
lines changed

.eslintrc.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ module.exports = {
66
},
77
extends: [
88
'plugin:@typescript-eslint/recommended',
9-
'prettier/@typescript-eslint',
10-
'plugin:prettier/recommended'
9+
'prettier'
1110
],
1211

1312
rules: {

package.json

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "bnc-onboard",
3-
"version": "1.27.0",
3+
"version": "1.28.0",
44
"description": "Onboard users to web3 by allowing them to select a wallet, get that wallet ready to transact and have access to synced wallet state.",
55
"keywords": [
66
"ethereum",
@@ -41,24 +41,27 @@
4141
"@typescript-eslint/parser": "^2.30.0",
4242
"babel-plugin-external-helpers": "^6.18.0",
4343
"eslint": "^6.8.0",
44-
"eslint-config-prettier": "^6.11.0",
45-
"eslint-plugin-prettier": "^3.1.3",
44+
"eslint-config-prettier": "^8.3.0",
4645
"prettier": "^2.0.5",
4746
"rimraf": "^3.0.0",
4847
"rollup": "^1.27.5",
49-
"rollup-plugin-svelte": "^5.0.3",
48+
"rollup-plugin-svelte": "^6.1.1",
5049
"rollup-plugin-typescript2": "0.21.0",
5150
"svelte": "^3.12.1",
5251
"svelte-i18n": "^1.1.2-beta",
5352
"typescript": "^3.6.4"
5453
},
5554
"dependencies": {
5655
"@cvbb/eth-keyring": "^1.1.0",
57-
"@gnosis.pm/safe-apps-provider": "^0.3.0",
58-
"@gnosis.pm/safe-apps-sdk": "^2.3.0",
56+
"@gnosis.pm/safe-apps-provider": "^0.5.0",
57+
"@gnosis.pm/safe-apps-sdk": "^3.0.0",
5958
"@ledgerhq/hw-app-eth": "^5.49.0",
6059
"@ledgerhq/hw-transport-u2f": "^5.21.0",
60+
"@ledgerhq/hw-transport-webusb": "5.53.0",
6161
"@portis/web3": "^4.0.0",
62+
"@shapeshiftoss/hdwallet-core": "^1.15.2",
63+
"@shapeshiftoss/hdwallet-keepkey": "^1.15.2",
64+
"@shapeshiftoss/hdwallet-keepkey-webusb": "^1.15.2",
6265
"@toruslabs/torus-embed": "^1.10.11",
6366
"@walletconnect/web3-provider": "^1.4.1",
6467
"authereum": "^0.1.12",

rollup.config.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ export default {
7373
'@cvbb/eth-keyring',
7474
'hdkey',
7575
'@ledgerhq/hw-transport-u2f',
76+
'@ledgerhq/hw-transport-webusb',
7677
'@ledgerhq/hw-app-eth',
7778
'util',
7879
'assert',
@@ -84,6 +85,9 @@ export default {
8485
'web3-provider-engine/subproviders/subscriptions',
8586
'web3-provider-engine/subproviders/filters',
8687
'eth-provider',
88+
'@shapeshiftoss/hdwallet-keepkey',
89+
'@shapeshiftoss/hdwallet-keepkey-webusb',
90+
'@shapeshiftoss/hdwallet-core',
8791
'@gnosis.pm/safe-apps-sdk',
8892
'@gnosis.pm/safe-apps-provider'
8993
]

src/@types/index.d.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,11 @@ declare module 'ethereumjs-util'
1414
declare module 'hdkey'
1515
declare module '@ledgerhq/hw-app-eth'
1616
declare module '@ledgerhq/hw-transport-u2f'
17+
declare module '@ledgerhq/hw-transport-webusb'
1718
declare module 'eth-provider'
1819

20+
declare module '@shapeshiftoss/hdwallet-core'
21+
declare module '@shapeshiftoss/hdwallet-keepkey-webusb'
22+
1923
declare module '*.png'
2024
declare module '*.svg'

src/interfaces.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,7 @@ export interface WalletModule {
113113
iconSrc?: string
114114
iconSrcSet?: string
115115
svg?: string
116-
wallet: (
117-
helpers: Helpers
118-
) => Promise<{
116+
wallet: (helpers: Helpers) => Promise<{
119117
provider: any | undefined
120118
interface: WalletInterface | null
121119
instance?: any

src/modules/check/accounts.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,9 @@ function accountSelect(
5353
}
5454

5555
const accountSelect = () => {
56-
const accountIndex = (document as any).getElementById('account-select')
57-
.selectedIndex
56+
const accountIndex = (document as any).getElementById(
57+
'account-select'
58+
).selectedIndex
5859

5960
provider.setPrimaryAccount(accountsAndBalances[accountIndex].address)
6061
}

src/modules/check/connect.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ function connect(options: WalletCheckCustomOptions = {}): WalletCheckModule {
2222
setTimeout(() => {
2323
if (address === null) {
2424
// if prom isn't resolving after 500ms, then stop waiting
25-
resolve()
25+
resolve(undefined)
2626
}
2727
}, 500)
2828
})

src/modules/check/derivation-path.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ const derivationPaths: DerivationPaths = {
1111
{ path: `m/44'/60'`, label: 'Ethereum Ledger Live' }
1212
],
1313
Trezor: [{ path: `m/44'/60'/0'/0`, label: 'Ethereum' }],
14-
Lattice: [{ path: `m/44'/60'/0'/0`, label: 'Ethereum' }]
14+
Lattice: [{ path: `m/44'/60'/0'/0`, label: 'Ethereum' }],
15+
KeepKey: [{ path: `m/44'/60'/0'/0/0`, label: 'Ethereum' }]
1516
}
1617

1718
const styles = `

src/modules/select/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,7 @@ function select(
6868
)
6969
}
7070

71-
function getModule(
72-
name: string
73-
): Promise<{
71+
function getModule(name: string): Promise<{
7472
default: (options: AllWalletInitOptions) => WalletModule
7573
}> {
7674
switch (name) {
@@ -142,6 +140,8 @@ function getModule(
142140
return import('./wallets/alphawallet')
143141
case 'ownbit':
144142
return import('./wallets/ownbit')
143+
case 'keepkey':
144+
return import('./wallets/keepkey/')
145145
case 'bitpie':
146146
return import('./wallets/bitpie')
147147
case 'gnosis':
16.2 KB
Loading

0 commit comments

Comments
 (0)