fix: Add option to hide the where is my wallet notice (#1786)

usame-algan · Adamj1232 · web-flow · commit bda34754b6a7 · 2023-06-29T08:39:41.000-06:00
* fix: Add option to hide the where is my wallet notice

* chore: Bump version

* Format and update docs

---------

Co-authored-by: Adam Carpenter &lt;adamcarpenter86@gmail.com&gt;
diff --git a/docs/src/routes/docs/[...3]modules/[...1]core/+page.md b/docs/src/routes/docs/[...3]modules/[...1]core/+page.md
@@ -19,6 +19,7 @@ This is the core package that contains all of the UI and logic to be able to sea
 
 :::admonition type="tip"
 _note: Release 2.24.0 moves the default position of the account center from topRight to bottomRight. To reset your application to topRight, include the following when initializing onboard:_
+
 ```typescript
   accountCenter: {
       desktop: {
@@ -31,6 +32,7 @@ _note: Release 2.24.0 moves the default position of the account center from topR
       }
     }
 ```
+
 :::
 
 ## Install
@@ -279,6 +281,10 @@ type ConnectModalOptions = {
    * Defaults to `https://www.blocknative.com/blog/metamask-wont-connect-web3-wallet-troubleshooting`
    */
   wheresMyWalletLink?: string
+  /**
+   * Hide the where is my wallet link notice displayed in the connect modal
+   */
+  hideWhereIsMyWallet?: boolean
   /**
    * @deprecated Has no effect unless `@web3-onboard/unstoppable-resolution`
    * package has been added and passed into the web3-onboard initialization
diff --git a/packages/core/README.md b/packages/core/README.md
@@ -7,6 +7,7 @@
 This is the core package that contains all of the UI and logic to be able to seamlessly connect user's wallets to your app and track the state of those wallets. Onboard no longer contains any wallet specific code, so wallets need to be passed in upon initialization.
 
 _Tip: Release 2.24.0 moves the default position of the account center from topRight to bottomRight. To reset your application to topRight, include the following when initializing onboard:_
+
 ```typescript
   accountCenter: {
       desktop: {
@@ -246,6 +247,10 @@ type ConnectModalOptions = {
    * Defaults to `https://www.blocknative.com/blog/metamask-wont-connect-web3-wallet-troubleshooting`
    */
   wheresMyWalletLink?: string
+  /**
+   * Hide the where is my wallet link notice displayed in the connect modal
+   */
+  hideWhereIsMyWallet?: boolean
   /**
    * @deprecated Has no effect unless `@web3-onboard/unstoppable-resolution`
    * package has been added and passed into the web3-onboard initialization
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/core",
-  "version": "2.20.4-alpha.1",
+  "version": "2.20.4-alpha.2",
   "description": "Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
   "keywords": [
     "Ethereum",
diff --git a/packages/core/src/types.ts b/packages/core/src/types.ts
@@ -179,7 +179,7 @@ export interface AppState {
   locale: Locale
   notify: Notify
   notifications: Notification[]
-  connect: ConnectModalOptions,
+  connect: ConnectModalOptions
   appMetadata: AppMetadata
 }
 
@@ -243,6 +243,10 @@ export type ConnectModalOptions = {
    * metamask-wont-connect-web3-wallet-troubleshooting`
    */
   wheresMyWalletLink?: string
+  /**
+   * Hide the where is my wallet link notice displayed in the connect modal
+   */
+  hideWhereIsMyWallet?: boolean
   /**
    * @deprecated Has no effect unless `@web3-onboard/unstoppable-resolution`
    * package has been added and passed into the web3-onboard initialization
@@ -429,7 +433,7 @@ export type Action =
   | AddNotificationAction
   | RemoveNotificationAction
   | UpdateAllWalletsAction
-  | UpdateConnectModalAction 
+  | UpdateConnectModalAction
   | UpdateAppMetadataAction
 
 export type AddChainsAction = { type: 'add_chains'; payload: Chain[] }
diff --git a/packages/core/src/validation.ts b/packages/core/src/validation.ts
@@ -202,6 +202,7 @@ const connectModalOptions = Joi.object({
   autoConnectAllPreviousWallet: Joi.boolean(),
   iDontHaveAWalletLink: Joi.string(),
   wheresMyWalletLink: Joi.string(),
+  hideWhereIsMyWallet: Joi.boolean(),
   disableUDResolution: Joi.boolean()
 })
 
diff --git a/packages/core/src/views/connect/SelectingWallet.svelte b/packages/core/src/views/connect/SelectingWallet.svelte
@@ -88,20 +88,25 @@
           connectingWalletLabel !== wallet.label}
       />
     {/each}
-    <div class="notice-container">
-      <Warning>
-        <div>{$_('connect.selectingWallet.whyDontISeeMyWallet', {
-          default: en.connect.selectingWallet.whyDontISeeMyWallet
-        })}</div>
-        <a
-          class="link pointer"
-          href={connect.wheresMyWalletLink || wheresMyWalletDefault}
-          target="_blank"
-          rel="noreferrer noopener">{$_('connect.selectingWallet.learnMore', {
-            default: en.connect.selectingWallet.learnMore
-          })}</a
-        >
-      </Warning>
-    </div>
+    {#if !connect.hideWhereIsMyWallet}
+      <div class="notice-container">
+        <Warning>
+          <div>
+            {$_('connect.selectingWallet.whyDontISeeMyWallet', {
+              default: en.connect.selectingWallet.whyDontISeeMyWallet
+            })}
+          </div>
+          <a
+            class="link pointer"
+            href={connect.wheresMyWalletLink || wheresMyWalletDefault}
+            target="_blank"
+            rel="noreferrer noopener"
+            >{$_('connect.selectingWallet.learnMore', {
+              default: en.connect.selectingWallet.learnMore
+            })}</a
+          >
+        </Warning>
+      </div>
+    {/if}
   </div>
 </div>
diff --git a/packages/demo/package.json b/packages/demo/package.json
@@ -27,7 +27,7 @@
     "@web3-onboard/cede-store": "^2.0.2",
     "@web3-onboard/blocto": "2.0.0",
     "@web3-onboard/coinbase": "^2.2.3",
-    "@web3-onboard/core": "^2.20.3",
+    "@web3-onboard/core": "^2.20.4-alpha.2",
     "@web3-onboard/dcent": "^2.2.7",
     "@web3-onboard/enkrypt": "^2.0.3",
     "@web3-onboard/fortmatic": "^2.0.18",
diff --git a/packages/demo/src/App.svelte b/packages/demo/src/App.svelte
@@ -293,7 +293,7 @@
     ],
     connect: {
       // disableClose: true,
-      autoConnectLastWallet: true,
+      // hideWhereIsMyWallet: true,
       autoConnectAllPreviousWallet: true
     },
     appMetadata: {
diff --git a/packages/react/package.json b/packages/react/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/react",
-  "version": "2.8.9-alpha.1",
+  "version": "2.8.9-alpha.2",
   "description": "A collection of React hooks for integrating Web3-Onboard in to React and Next.js projects. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
   "keywords": [
     "Ethereum",
@@ -63,7 +63,7 @@
   },
   "dependencies": {
     "@web3-onboard/common": "^2.3.3",
-    "@web3-onboard/core": "^2.20.4-alpha.1",
+    "@web3-onboard/core": "^2.20.4-alpha.2",
     "use-sync-external-store": "1.0.0"
   },
   "peerDependencies": {
diff --git a/packages/vue/package.json b/packages/vue/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/vue",
-  "version": "2.7.8-alpha.1",
+  "version": "2.7.8-alpha.2",
   "description": "A collection of Vue Composables for integrating Web3-Onboard in to a Vue or Nuxt project. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
   "keywords": [
     "Ethereum",
@@ -63,7 +63,7 @@
     "@vueuse/core": "^8.4.2",
     "@vueuse/rxjs": "^8.2.0",
     "@web3-onboard/common": "^2.3.3",
-    "@web3-onboard/core": "^2.20.4-alpha.1",
+    "@web3-onboard/core": "^2.20.4-alpha.2",
     "vue-demi": "^0.12.4"
   },
   "peerDependencies": {
diff --git a/yarn.lock b/yarn.lock
@@ -3906,25 +3906,6 @@
     "@walletconnect/window-getters" "^1.0.1"
     tslib "1.14.1"
 
-"@web3-onboard/core@^2.20.3":
-  version "2.20.3"
-  resolved "https://registry.yarnpkg.com/@web3-onboard/core/-/core-2.20.3.tgz#e123979f9360057cd184d715fdedc9f0bbf45941"
-  integrity sha512-2fm8kJ4T4DXvPNU7rjWCAxFFEZXx2Xz7LiUCg+qXvhiHzJBBxGOBbL81HwZk9hR3eZzWwQt9tLmbFx0G2uREow==
-  dependencies:
-    "@web3-onboard/common" "^2.3.3"
-    bignumber.js "^9.0.0"
-    bnc-sdk "^4.6.7"
-    bowser "^2.11.0"
-    ethers "5.5.3"
-    eventemitter3 "^4.0.7"
-    joi "17.9.1"
-    lodash.merge "^4.6.2"
-    lodash.partition "^4.6.0"
-    nanoid "^4.0.0"
-    rxjs "^7.5.5"
-    svelte "^3.49.0"
-    svelte-i18n "^3.3.13"
-
 "@web3-react/abstract-connector@^6.0.7":
   version "6.0.7"
   resolved "https://registry.yarnpkg.com/@web3-react/abstract-connector/-/abstract-connector-6.0.7.tgz#401b3c045f1e0fab04256311be49d5144e9badc6"

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@web3-onboard/core",`
`3`		`- "version": "2.20.4-alpha.1",`
	`3`	`+ "version": "2.20.4-alpha.2",`
`4`	`4`	`"description": "Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"Ethereum",`