Skip to content

Commit eb205fb

Browse files
authored
[FIX] : Core package check and passing of protectedRpcUrl on account center disconnect (#2234)
* Fix check and passing of protectedRpcUrl on account center disconnect * Revert changes to the internal demo
1 parent 26e9991 commit eb205fb

File tree

7 files changed

+12
-11
lines changed

7 files changed

+12
-11
lines changed

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@web3-onboard/core",
3-
"version": "2.22.1",
3+
"version": "2.22.2-alpha.1",
44
"description": "Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
55
"keywords": [
66
"Ethereum",

packages/core/src/views/account-center/AccountCenterPanel.svelte

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@
7272
const { device } = configuration
7373
7474
const enableProtectionRPC = async () => {
75+
if (!validAppChain) return
7576
try {
7677
await updateChainRPC(
7778
primaryWallet.provider,
@@ -461,7 +462,7 @@
461462
</div>
462463
</div>
463464
<!-- Only display on Eth Mainnet if protectedRpcUrl is not set per chain -->
464-
{#if !$accountCenter$.hideTransactionProtectionBtn && (primaryWalletOnMainnet || validAppChain.protectedRpcUrl)}
465+
{#if !$accountCenter$.hideTransactionProtectionBtn && (primaryWalletOnMainnet || (validAppChain && validAppChain.protectedRpcUrl))}
465466
<div
466467
on:click={() => (enableTransactionProtection = true)}
467468
class="protect action-container flex items-center pointer"

packages/demo/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333
"@web3-onboard/blocto": "^2.1.1",
3434
"@web3-onboard/capsule": "2.2.0-alpha.1",
3535
"@web3-onboard/cede-store": "^2.3.1",
36+
"@web3-onboard/core": "2.22.2-alpha.1",
3637
"@web3-onboard/coinbase": "^2.4.1",
37-
"@web3-onboard/core": "2.22.1",
3838
"@web3-onboard/dcent": "^2.2.7",
3939
"@web3-onboard/enkrypt": "^2.1.1",
4040
"@web3-onboard/fortmatic": "^2.1.1",

packages/demo/src/App.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,9 +281,9 @@
281281
282282
const onboard = Onboard({
283283
wallets: [
284-
// metamaskSDKWallet,
285-
coinbaseWallet,
284+
metamaskSDKWallet,
286285
injected,
286+
coinbaseWallet,
287287
ledger,
288288
trezor,
289289
walletConnect,

packages/react/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@web3-onboard/react",
3-
"version": "2.9.1",
3+
"version": "2.9.2-alpha.1",
44
"description": "A collection of React hooks for integrating Web3-Onboard in to React and Next.js projects. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
55
"keywords": [
66
"Ethereum",
@@ -61,7 +61,7 @@
6161
"typescript": "^5.4.5"
6262
},
6363
"dependencies": {
64-
"@web3-onboard/core": "2.22.1",
64+
"@web3-onboard/core": "2.22.2-alpha.1",
6565
"@web3-onboard/common": "^2.4.1",
6666
"use-sync-external-store": "1.0.0"
6767
},

packages/solid/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@web3-onboard/solid",
3-
"version": "2.1.1",
3+
"version": "2.1.2-alpha.1",
44
"description": "A collection of solid Composables for integrating Web3-Onboard in to a Solid project. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
55
"keywords": [
66
"Ethereum",
@@ -63,7 +63,7 @@
6363
},
6464
"dependencies": {
6565
"@web3-onboard/common": "^2.4.1",
66-
"@web3-onboard/core": "2.22.1",
66+
"@web3-onboard/core": "2.22.2-alpha.1",
6767
"solid-js": "^1.8.1"
6868
}
6969
}

packages/vue/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@web3-onboard/vue",
3-
"version": "2.8.1",
3+
"version": "2.8.2-alpha.1",
44
"description": "A collection of Vue Composables for integrating Web3-Onboard in to a Vue or Nuxt project. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardized spec compliant web3 providers for all supported wallets, modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
55
"keywords": [
66
"Ethereum",
@@ -62,7 +62,7 @@
6262
"@vueuse/core": "^8.4.2",
6363
"@vueuse/rxjs": "^8.2.0",
6464
"@web3-onboard/common": "^2.4.1",
65-
"@web3-onboard/core": "2.22.1",
65+
"@web3-onboard/core": "2.22.2-alpha.1",
6666
"vue-demi": "^0.12.4"
6767
},
6868
"peerDependencies": {

0 commit comments

Comments
 (0)