Update handler of chainId within eth_chainId

Author: Adamj1232

packages/coinbase/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@web3-onboard/coinbase",
-  "version": "2.3.0-alpha.3",
+  "version": "2.3.0-alpha.4",
   "description": "Coinbase SDK wallet module for connecting to Web3-Onboard. Web3-Onboard makes it simple to connect Ethereum hardware and software wallets to your dapp. Features standardised spec compliant web3 providers for all supported wallets, framework agnostic modern javascript UI with code splitting, CSS customization, multi-chain and multi-account support, reactive wallet state subscriptions and real-time transaction state change notifications.",
   "keywords": [
     "Ethereum",

packages/coinbase/src/index.ts

@@ -1,7 +1,8 @@
-import type {
-  EIP1193Provider,
-  WalletInit,
-  WalletInterface
+import {
+  createEIP1193Provider,
+  fromHex,
+  type WalletInit,
+  type WalletInterface
 } from '@web3-onboard/common'
 
 function coinbaseWallet({
@@ -27,9 +28,9 @@ function coinbaseWallet({
         chains,
         appMetadata
       }): Promise<WalletInterface> => {
-        if (enableMobileWalletLink || reloadOnDisconnect) {
+        if (enableMobileWalletLink || reloadOnDisconnect || darkMode) {
           console.warn(
-            'enableMobileWalletLink and reloadOnDisconnect are deprecated after version 2.2.7 of @web3-onboard/coinbase'
+            'darkMode, enableMobileWalletLink and reloadOnDisconnect init props are deprecated after version 2.2.7 of @web3-onboard/coinbase'
           )
         }
         const { name, icon } = appMetadata || {}
@@ -50,9 +51,8 @@ function coinbaseWallet({
         const base64 = window.btoa(icon || '')
         const appLogoUrl = `data:image/svg+xml;base64,${base64}`
 
-        const appChainIds = chains.map(
-          // @ts-ignore - treating hex strings as numbers as they are expected to be hex numbers
-          ({ id }) => id as number
+        const appChainIds = chains.map(({ id }) =>
+          fromHex(id as `0x${string}`, 'number')
         )
 
         const instance = new CoinbaseWalletSDKConstructor({
@@ -89,9 +89,20 @@ function coinbaseWallet({
 
           return coinbaseWalletProvider
         }
+        const provider = createEIP1193Provider(coinbaseWalletProvider, {
+          eth_chainId: ({ baseRequest }) =>
+            baseRequest({ method: 'eth_chainId' }).then(id => {
+              if (isHex(id)) {
+                return id
+              } else {
+                return toHex(id)
+              }
+            })
+        })
+        provider.removeListener = (event, func) => {}
 
         return {
-          provider: coinbaseWalletProvider as EIP1193Provider,
+          provider,
           instance
         }
       }

packages/demo/package.json

@@ -33,7 +33,7 @@
     "@web3-onboard/capsule": "2.1.0-alpha.2",
     "@web3-onboard/cede-store": "^2.3.0-alpha.2",
     "@web3-onboard/core": "^2.22.0-alpha.5",
-    "@web3-onboard/coinbase": "^2.3.0-alpha.3",
+    "@web3-onboard/coinbase": "^2.3.0-alpha.4",
     "@web3-onboard/dcent": "^2.2.7",
     "@web3-onboard/enkrypt": "^2.1.0-alpha.2",
     "@web3-onboard/fortmatic": "^2.1.0-alpha.2",