-
Notifications
You must be signed in to change notification settings - Fork 537
Enhancement - Add viem support and remove ethers (NOT hw-wallets) #2190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to ensure the node engine check is enforced
…ted chain usage for ens and l2s, added function for handling decimel resolution with bigints
…perly reflect functionality
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
lnbc1QWFyb24
reviewed
May 9, 2024
lnbc1QWFyb24
reviewed
May 9, 2024
Closing as this will go out with wagmi support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes Ethers and Bignumber.js from Core, common and injected and implements Viem support to handle balance checking and ENS details fetching.
This resulted in reducing the bundle size of the core module from
861 kB
->459.8 kB
when minified!Bundlephobia for latest core & viem core
The packages are tagged with a
-viem.x
tag for release and testing in build envs.So far common, core and injected have successfully published and I will test with them. There after I will incrementally add other packages to test with.
Any feedback would be very helpful
This will remain in draft until all packages have been tested and are ready for an
alpha
release