feat: add passport wallet #2193
Conversation
packages/demo/package.json
Outdated
| "@0xpass/webauthn-signer": "2.0.0", | ||
| "@0xpass/passport": "2.1.1", |
There was a problem hiding this comment.
Are these deps required?
There was a problem hiding this comment.
Yes these deps are required
There was a problem hiding this comment.
Why are they required if they are part of the @web3-onboard/passport package dependencies?
There was a problem hiding this comment.
actually for this you're right passport can be removed but webauthn-signer is a required dependency. have made changes to reflect this in the latest commit
There was a problem hiding this comment.
@k-xo if it is required for the package to work should it be added to the package dependencies?
There was a problem hiding this comment.
@Adamj1232 We have multiple signer types, and support a specific signer interface, so this setup is setting up the flow where users are using passkeys / webauthn signer, so it is required in the application context of setting up the signer, and is the most convenient way of setting it up, however it is not required in the sense it should be included in the onboard package, in future would like to add other signer types as well, but just starting with passkeys, so setting it up this way makes it easier for us to be agnostic with the signer types
so in the demo we have the passport onboard package and the webauthn signer, but in the actual passport package we have the core passport sdk, as well as our viem client.
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
packages/passport/src/index.ts
Outdated
| @@ -0,0 +1,298 @@ | |||
| import { createEIP1193Provider, type WalletInit } from '@web3-onboard/common' | |||
There was a problem hiding this comment.
| import { createEIP1193Provider, type WalletInit } from '@web3-onboard/common' | |
| import type { WalletInit } from '@web3-onboard/common' |
Can you please split this out as well and dynamically import createEIP1193Provider within the getInterface method?
|
@Adamj1232 any pointer to fixing the build issue? haven't made any changes to any other packages, was working fine at a point, and now... isn't unsure why |
Description
Passport is an MPC-based programmable, distributed, and non-custodial key management system, that allows users to generate wallets, scoped to their application, either via user Passkeys, our signer allows you to sign messages and transactions with a Passport Network account.
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errorsDocs Checklist
docs/package.jsonfile (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn devto get the project running athttp://localhost:8080/Tests with demo app (injected)
Tests with demo app (SDK)