Enh - Coinbase dependency upgrade to 4.0 #2204
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,38 @@ | ||
| import { | ||
| createEIP1193Provider, | ||
| fromHex, | ||
| type WalletInit, | ||
| type WalletInterface | ||
| } from '@web3-onboard/common' | ||
|
|
||
| function coinbaseWallet({ | ||
| supportedWalletType = 'all', | ||
| darkMode = false, | ||
| enableMobileWalletLink = false, | ||
| reloadOnDisconnect = true | ||
| }: { | ||
| /** @deprecated Deprecated after version 2.2.7 of @web3-onboard/coinbase Use dark theme */ | ||
| darkMode?: boolean | ||
| /** @deprecated Deprecated after version 2.2.7 of @web3-onboard/coinbase whether to connect mobile web app via WalletLink, defaults to false */ | ||
| enableMobileWalletLink?: boolean | ||
| /** @deprecated Deprecated after version 2.2.7 of @web3-onboard/coinbase whether or not to reload dapp automatically after disconnect, defaults to true */ | ||
| reloadOnDisconnect?: boolean | ||
| /** Type of Coinbase wallets to support - options : 'all' | 'smartWalletOnly' | 'eoaOnly' - Default to `all` */ | ||
| supportedWalletType?: 'all' | 'smartWalletOnly' | 'eoaOnly' | ||
| } = {}): WalletInit { | ||
| return () => { | ||
| return { | ||
| label: 'Coinbase Wallet', | ||
| getIcon: async () => (await import('./icon.js')).default, | ||
| getInterface: async ({ | ||
| chains, | ||
| appMetadata | ||
| }): Promise<WalletInterface> => { | ||
| if (enableMobileWalletLink || reloadOnDisconnect || darkMode) { | ||
| console.warn( | ||
| 'darkMode, enableMobileWalletLink and reloadOnDisconnect init props are deprecated after version 2.2.7 of @web3-onboard/coinbase' | ||
| ) | ||
| } | ||
| const { name, icon } = appMetadata || {} | ||
|
|
||
| // according to https://github.com/wagmi-dev/wagmi/issues/383 | ||
|
|
@@ -31,29 +46,41 @@ function coinbaseWallet({ | |
| ? (CoinbaseWalletSDK as any).default | ||
| : CoinbaseWalletSDK | ||
| ) as typeof CoinbaseWalletSDK | ||
| const { isHex, toHex } = await import('@web3-onboard/common') | ||
|
|
||
| const base64 = window.btoa(icon || '') | ||
| const appLogoUrl = `data:image/svg+xml;base64,${base64}` | ||
|
|
||
| const appChainIds = chains.map(({ id }) => | ||
| fromHex(id as `0x${string}`, 'number') | ||
| ) | ||
|
|
||
| const instance = new CoinbaseWalletSDKConstructor({ | ||
| appName: name || '', | ||
| appLogoUrl, | ||
| appChainIds | ||
| }) | ||
|
|
||
| const coinbaseWalletProvider = instance.makeWeb3Provider({ | ||
| options: supportedWalletType | ||
| }) | ||
|
|
||
| // patch the chainChanged event | ||
| const on = coinbaseWalletProvider.on.bind(coinbaseWalletProvider) | ||
|
|
||
| coinbaseWalletProvider.on = (event, listener) => { | ||
| // @ts-ignore | ||
| on(event, val => { | ||
| if (event === 'chainChanged') { | ||
| let hexVal: string | ||
| if (isHex(val)) { | ||
| hexVal = val | ||
| } else { | ||
| hexVal = toHex(val) | ||
| } | ||
|
|
||
| // @ts-ignore | ||
| listener(hexVal) | ||
| return | ||
| } | ||
|
|
||
|
|
@@ -62,9 +89,20 @@ function coinbaseWallet({ | |
|
|
||
| return coinbaseWalletProvider | ||
| } | ||
| const provider = createEIP1193Provider(coinbaseWalletProvider, { | ||
| eth_chainId: ({ baseRequest }) => | ||
|
There was a problem hiding this comment. @nateReiners patched provider to handle number value returned from There was a problem hiding this comment. @Adamj1232 If you want to bump the sdk to 4.0.3 and get rid of this workaround, the version with the There was a problem hiding this comment. @nateReiners when I remove the patch and |
||
| baseRequest({ method: 'eth_chainId' }).then(id => { | ||
| if (isHex(id)) { | ||
| return id | ||
| } else { | ||
| return toHex(id) | ||
| } | ||
| }) | ||
| }) | ||
| provider.removeListener = (event, func) => {} | ||
|
|
||
| return { | ||
| provider, | ||
| instance | ||
| } | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.