Update accent handling #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use long press - generalize `AccentKeyButton` - rm accent button from french keyboard, not needed as long press is used
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10 +/- ##
==========================================
- Coverage 77.51% 77.47% -0.05%
==========================================
Files 7 7
Lines 378 435 +57
==========================================
+ Hits 293 337 +44
- Misses 85 98 +13
☔ View full report in Codecov by Sentry. |
- squashed
- finish - danish - norwegian - swedish (cherry picked from commit 5b909d4dfbdceddbe9c9e47c5d6e818075e4a05c)
- finnish - norwegian
Add support for scandinvaian languages
- can be used for a lot of latinous languaes - supports some common diacritics - uses Unicode combining charactes (U+0300–U+036F)
Add general latin language layout
- refactor View.keyboardBackground -> KeyboardTheme - use `@ViewBuilder` instead of `return AnyView` - use `Rectangle().fill(.clear)` instead `AnyView(EmptyView())`
- refactor View.keyboardBackground -> KeyboardTheme - use `@ViewBuilder` instead of `return AnyView` - use `Rectangle().fill(.clear)` instead `AnyView(EmptyView())`
Add clear theme
- i18n (cherry picked from commit d7b7f1c7cb7c424386f500b453345d8673dbf5fd)
|
Kudos, SonarCloud Quality Gate passed!
|
- add Korean - update yeartext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AccentKeyButtonLanguage.latinWithAccentsKeyboardTheme.clear