Exchange-Detail, Detail-Popup #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thongdanghoang
requested changes
Jun 18, 2024
| const applicationService = useApplicationService(); | ||
|
|
||
| // Fetch product detail by id | ||
| const {id} = useParams<{id: string}>(); |
There was a problem hiding this comment.
what's does id and second id mean???? use more meaningful variable name
|
|
||
| // Fetch product detail by id | ||
| const {id} = useParams<{id: string}>(); | ||
| const {secondId} = useParams<{secondId: string}>(); |
| .createApiClient() | ||
| .get(`${AppRoutingConstants.PRODUCTS_PATH}/${secondId}`) | ||
| .then(response => { | ||
| console.log(response); |
There was a problem hiding this comment.
never commit console.log to PR
| @import "@assets/styles/variables"; | ||
|
|
||
| .exchange-detail { | ||
| .halftop-box { |
There was a problem hiding this comment.
what's halftop-box ??? use always use meaningful variables name
| border-bottom: 0; | ||
| } | ||
|
|
||
| .halfbottom-box { |
There was a problem hiding this comment.
use meaningful variable name
| </div> | ||
| </div> | ||
| </div> | ||
| {/* Stepper */} |
There was a problem hiding this comment.
Never comment code, if this is not done, create TODO or JIRA ticket implement later
| <AppButton | ||
| className="button" | ||
| variant={'primary'} | ||
| // onClick={} |
| <AppButton | ||
| className="button" | ||
| variant={'tertiary'} | ||
| // onClick={} |
| @@ -111,7 +111,9 @@ export default function ExchangeRequest(): ReactElement { | |||
| .createApiClient() | |||
| .post(AppRoutingConstants.EXCHANGE_REQUESTS_PATH, exchangeRequest) | |||
| .then((): void => { | |||
| navigate(AppRoutingConstants.HOMEPAGE); | |||
| navigate( | |||
| `/exchange-detail/${currentProduct?.id}/${selectedProductId}` | |||
There was a problem hiding this comment.
why don't define variable in AppRoutingConstants -> remove hardcode
| @@ -266,6 +268,7 @@ export default function ExchangeRequest(): ReactElement { | |||
| variant={'primary'} | |||
| disabled={!confirm || !selectedProductId} | |||
| onClick={handleExchangeRequestByProduct} | |||
| // onClick={() => navigate(`/exchange-detail/${currentProduct?.id}`)} | |||
There was a problem hiding this comment.
why comment out instead remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.