Feature/swd 43 post preview and validation #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thongdanghoang
requested changes
Jun 18, 2024
| </Form.Group> | ||
| </Modal.Body> | ||
| <Modal.Footer> | ||
| {/* <AppButton variant="secondary" onClick={hideModal}>*/} |
There was a problem hiding this comment.
why comment out of this section? if not use, remove it, Github already save our life
| @@ -26,4 +26,163 @@ | |||
| } | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @mixin form-validation-state-selector($state) { | |||
There was a problem hiding this comment.
use meaningful variable instead, which form will apply, what's this validate?
| } | ||
| } | ||
|
|
||
| // stylelint-disable-next-line selector-no-qualifying-type |
There was a problem hiding this comment.
why disable stylelint? explain reason, if not, never by pass eslint and stylelint without reason
frontend/src/modules/products/components/post-product/PostProduct.tsx
Outdated
Show resolved
Hide resolved
| @@ -32,7 +37,7 @@ export default function PostProduct(): ReactElement { | |||
| // for example, you could return a loading spinner | |||
| return <div>Loading...</div>; | |||
There was a problem hiding this comment.
remove it, we already have snipper loading when call api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hiện tại là xong validation (trừ mục địa chỉ), preview em chỉ mới đang câu từ cái address qua nên chưa chỉnh, còn về phần giao diện như bên Hiếu thì em có bỏ thử nhưng nó lỗi mấy chỗ interface nên em chưa bưng từ bên đó qua đc do em chưa biết chỉnh