Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Fix passkey bug -> no authorities #150

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Conversation

GiaBaorr
Copy link
Collaborator

@GiaBaorr GiaBaorr commented Feb 22, 2025

Summary by CodeRabbit

  • New Features
    • Enhanced logout functionality: Users can now sign out via a secure form submission, ensuring a smoother and safer logout process.
    • Improved access control: Adjustments to authentication processes provide clearer and more robust permission handling during sign-in and sign-up flows.
    • Added support for retrieving user authorities in the authentication process.

Copy link

coderabbitai bot commented Feb 22, 2025

Walkthrough

The changes update the security configuration and logout functionality. The backend now explicitly permits and configures the /logout endpoint for unauthenticated access, while the frontend transitions from a GET logout link to a POST form. Additionally, a new getAuthorities() method is added to the token class to supply user authority details.

Changes

File(s) Summary
sep490-idp/.../configs/MvcSecurityConfig.java
sep490-idp/.../templates/account-page.html
Updated logout behavior: expanded unauthenticated access to /logout, defined logout URL in security configuration, and replaced a GET logout link with a POST form submission in the account page.
sep490-idp/.../security/PasskeyAuthenticationToken.java Added new getAuthorities() method that retrieves a collection of GrantedAuthority objects from the user context.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant B as Browser
    participant S as Server
    U->>B: Click logout button
    B->>S: Submit POST /logout form
    S-->>B: Process logout and return response
Loading

Suggested labels

improvement

Suggested reviewers

  • thongdanghoang
  • huynhlephcvinh

Poem

I'm a coding rabbit on a joyful spree,
Hopping through changes, light as can be.
Logout now posts with a secure new vibe,
And getAuthorities() helps the code thrive.
With each bug hopped over, I cheer and repeat—
A byte-sized celebration, oh so sweet! 🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 398296e and f18528d.

📒 Files selected for processing (3)
  • sep490-idp/src/main/java/green_buildings/idp/configs/MvcSecurityConfig.java (2 hunks)
  • sep490-idp/src/main/java/green_buildings/idp/security/PasskeyAuthenticationToken.java (2 hunks)
  • sep490-idp/src/main/resources/templates/account-page.html (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • sep490-idp/src/main/java/green_buildings/idp/security/PasskeyAuthenticationToken.java
  • sep490-idp/src/main/resources/templates/account-page.html
  • sep490-idp/src/main/java/green_buildings/idp/configs/MvcSecurityConfig.java
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build Java Modules (sep490-enterprise)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nganntqe170236 nganntqe170236 merged commit 86afe41 into main Feb 22, 2025
8 checks passed
@nganntqe170236 nganntqe170236 deleted the feature/passkey-bug branch February 22, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants