fix: add the correct enterkeyhint to the comment composer #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. @maddernd you can review this now. |
|
Yes this approved please make upstream. |
|
Closed in favor of doubtfire-lms#827 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Was trying to reproduce doubtfire-lms#705 and turns out it's already fixed in development. Only remaining thing to address was enterkeyhint, which makes enter buttons on mobile devices display the correct icon or text.
Type of change
How Has This Been Tested?
Tested sending messages and making sure the enter key has the correct icon/text on iOS 17.3.1 with Safari, and on Android 14 with Firefox
Before:
After:
Testing Checklist:
Checklist: