feat: change node certification when node resources updated (#458)

Author: DylanVerstraete

substrate-node/pallets/pallet-tfgrid/src/lib.rs

@@ -1055,6 +1055,17 @@ pub mod pallet {
                 NodesByFarmID::<T>::insert(farm_id, nodes_by_farm);
             };
 
+            // If the resources on a certified node changed, reset the certification level to DIY
+            if stored_node.resources != resources
+                && stored_node.certification == NodeCertification::Certified
+            {
+                stored_node.certification = NodeCertification::Diy;
+                Self::deposit_event(Event::NodeCertificationSet(
+                    node_id,
+                    stored_node.certification,
+                ));
+            }
+
             stored_node.farm_id = farm_id;
             stored_node.resources = resources;
             stored_node.location = location;

substrate-node/pallets/pallet-tfgrid/src/tests.rs

@@ -705,6 +705,101 @@ fn update_node_moved_from_farm_list_works() {
     });
 }
 
+#[test]
+fn update_certified_node_resources_loses_certification_works() {
+    ExternalityBuilder::build().execute_with(|| {
+        create_entity();
+        create_twin();
+        create_farm();
+        create_node();
+
+        assert_ok!(TfgridModule::add_node_certifier(
+            RawOrigin::Root.into(),
+            alice()
+        ));
+
+        assert_ok!(TfgridModule::set_node_certification(
+            Origin::signed(alice()),
+            1,
+            NodeCertification::Certified
+        ));
+
+        let node = TfgridModule::nodes(1).unwrap();
+        assert_eq!(node.certification, NodeCertification::Certified);
+
+        // Change cores to 2
+        let mut node_resources = node.resources;
+        node_resources.cru = 2;
+
+        assert_ok!(TfgridModule::update_node(
+            Origin::signed(alice()),
+            1,
+            1,
+            node_resources,
+            node.location,
+            node.country,
+            node.city,
+            Vec::new().try_into().unwrap(),
+            true,
+            true,
+            "some_serial".as_bytes().to_vec(),
+        ));
+
+        let our_events = System::events();
+        assert_eq!(
+            our_events.contains(&record(MockEvent::TfgridModule(
+                TfgridEvent::<TestRuntime>::NodeCertificationSet(1, NodeCertification::Diy)
+            ))),
+            true
+        );
+
+        let node = TfgridModule::nodes(1).unwrap();
+        assert_eq!(node.certification, NodeCertification::Diy);
+    });
+}
+
+#[test]
+fn update_certified_node_same_resources_keeps_certification_works() {
+    ExternalityBuilder::build().execute_with(|| {
+        create_entity();
+        create_twin();
+        create_farm();
+        create_node();
+
+        assert_ok!(TfgridModule::add_node_certifier(
+            RawOrigin::Root.into(),
+            alice()
+        ));
+
+        assert_ok!(TfgridModule::set_node_certification(
+            Origin::signed(alice()),
+            1,
+            NodeCertification::Certified
+        ));
+
+        let node = TfgridModule::nodes(1).unwrap();
+        assert_eq!(node.certification, NodeCertification::Certified);
+
+        // Don't change resources
+        assert_ok!(TfgridModule::update_node(
+            Origin::signed(alice()),
+            1,
+            1,
+            node.resources,
+            node.location,
+            node.country,
+            node.city,
+            Vec::new().try_into().unwrap(),
+            true,
+            true,
+            "some_serial".as_bytes().to_vec(),
+        ));
+
+        let node = TfgridModule::nodes(1).unwrap();
+        assert_eq!(node.certification, NodeCertification::Certified);
+    });
+}
+
 #[test]
 fn create_node_with_interfaces_works() {
     ExternalityBuilder::build().execute_with(|| {