@@ -9,7 +9,7 @@ use sp_std::marker::PhantomData;
9
9
// 1: Y
10
10
pub const MIN_CITY_NAME_LENGTH : u32 = 1 ;
11
11
// 85: Llanfairpwllgwyngyllgogerychwyrndrobwllllantysiliogogogoch
12
- pub const MAX_CITY_NAME_LENGTH : u32 = 58 ;
12
+ pub const MAX_CITY_NAME_LENGTH : u32 = 100 ;
13
13
pub const DEFAULT_CITY_NAME : & [ u8 ] = b"Unknown" ;
14
14
15
15
/// A city name in ASCI Characters.
@@ -36,7 +36,6 @@ impl<T: Config> TryFrom<CityNameInput> for CityName<T> {
36
36
value. len( ) <= MAX_CITY_NAME_LENGTH . saturated_into( ) ,
37
37
Self :: Error :: CityNameTooLong
38
38
) ;
39
- ensure ! ( validate_city_name( & value) , Self :: Error :: InvalidCityName ) ;
40
39
41
40
Ok ( Self ( value, PhantomData ) )
42
41
}
@@ -65,22 +64,10 @@ impl<T: Config> Clone for CityName<T> {
65
64
}
66
65
}
67
66
68
- pub fn validate_city_name ( input : & [ u8 ] ) -> bool {
69
- input == DEFAULT_CITY_NAME
70
- || match core:: str:: from_utf8 ( input) {
71
- Ok ( val) => val
72
- . chars ( )
73
- . all ( |c| c. is_alphabetic ( ) || matches ! ( c, '-' | '.' | ' ' ) ) ,
74
- Err ( _) => false ,
75
- }
76
- // we convert to &str and then to chars to handle
77
- // special alphabetic characters thanks to is_alphabetic()
78
- }
79
-
80
67
// 2: Allow country code like BE, FR, BR, ...
81
68
pub const MIN_COUNTRY_NAME_LENGTH : u32 = 2 ;
82
69
// 56: The United Kingdom of Great Britain and Northern Ireland
83
- pub const MAX_COUNTRY_NAME_LENGTH : u32 = 56 ;
70
+ pub const MAX_COUNTRY_NAME_LENGTH : u32 = 100 ;
84
71
pub const DEFAULT_COUNTRY_NAME : & [ u8 ] = b"Unknown" ;
85
72
86
73
/// A city name in ASCI Characters.
@@ -107,10 +94,6 @@ impl<T: Config> TryFrom<CountryNameInput> for CountryName<T> {
107
94
value. len( ) <= MAX_COUNTRY_NAME_LENGTH . saturated_into( ) ,
108
95
Self :: Error :: CountryNameTooLong
109
96
) ;
110
- ensure ! (
111
- validate_country_name( & value) ,
112
- Self :: Error :: InvalidCountryName
113
- ) ;
114
97
115
98
Ok ( Self ( value, PhantomData ) )
116
99
}
@@ -139,18 +122,6 @@ impl<T: Config> Clone for CountryName<T> {
139
122
}
140
123
}
141
124
142
- pub fn validate_country_name ( input : & [ u8 ] ) -> bool {
143
- input == DEFAULT_COUNTRY_NAME
144
- || match core:: str:: from_utf8 ( input) {
145
- Ok ( val) => val
146
- . chars ( )
147
- . all ( |c| c. is_alphabetic ( ) || matches ! ( c, '-' | '.' | ' ' ) ) ,
148
- Err ( _) => false ,
149
- }
150
- // we convert to &str and then to chars to handle
151
- // special alphabetic characters thanks to is_alphabetic()
152
- }
153
-
154
125
pub const MIN_LATITUDE_LENGTH : u32 = 1 ;
155
126
pub const MAX_LATITUDE_LENGTH : u32 = 50 ;
156
127
pub const DEFAULT_LATITUDE : & [ u8 ] = b"Unknown" ;
@@ -354,29 +325,6 @@ pub fn validate_serial_number(input: &[u8]) -> bool {
354
325
} )
355
326
}
356
327
357
- #[ test]
358
- fn test_validate_city_name_works ( ) {
359
- assert_eq ! ( validate_city_name( b"Rio de Janeiro" ) , true ) ;
360
- assert_eq ! ( validate_city_name( b"Ghent" ) , true ) ;
361
- assert_eq ! ( validate_city_name( b"Cairo" ) , true ) ;
362
- assert_eq ! (
363
- validate_city_name( & vec![ 76 , 105 , 195 , 168 , 103 , 101 ] ) , // b"Liège"
364
- true
365
- ) ;
366
-
367
- assert_eq ! ( validate_city_name( b"Los_Angeles" ) , false ) ;
368
- }
369
-
370
- #[ test]
371
- fn test_validate_country_name_works ( ) {
372
- assert_eq ! ( validate_country_name( b"Brazil" ) , true ) ;
373
- assert_eq ! ( validate_country_name( b"Belgium" ) , true ) ;
374
- assert_eq ! ( validate_country_name( b"Egypt" ) , true ) ;
375
- assert_eq ! ( validate_country_name( b"U.S.A" ) , true ) ;
376
-
377
- assert_eq ! ( validate_country_name( b"Costa_Rica" ) , false ) ;
378
- }
379
-
380
328
#[ test]
381
329
fn test_validate_latitude_input_works ( ) {
382
330
assert_eq ! ( validate_latitude_input( b"90.0" ) , true ) ;
0 commit comments