update twin with myc pk #1037
Draft
update twin with myc pk #1037
+229
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omarabdul3ziz
force-pushed
the
development_TwinMycPK
branch
from
a39c1c0 to
f1e77f1
Compare
- add storage map from myc-pk -> twin-id - add setter function to set twin-id for myc-pk - update clients with setter/getter functions
Omarabdul3ziz
force-pushed
the
development_TwinMycPK
branch
from
f1e77f1 to
135adcf
Compare
Omarabdul3ziz
force-pushed
the
development_TwinMycPK
branch
from
b557493 to
3fd0ab0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a draft, sameh suggested to add new storage for the twin->myc-pk mapping. it is safer to migrate