Skip to content

Fix: Adding min threshold and duration for dao motion #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sameh-farouk
Copy link
Member

@sameh-farouk sameh-farouk commented Jun 3, 2024

Description

  • What does this PR do?

    • Adding a minimum for the threshold (5) that the user provide when submitting a Dao proposal
    • Adding a minimum for the duration (1 day) that the user may provide when submitting a Dao proposal
    • Update Docs
    • Update and adding relevant tests
  • Why are these changes needed?

    • A low threshold with a short voting time could result in a proposal passing without farmers even knowing that the proposal took place.
  • How were these changes implemented and what do they affect?

    • These changes affected the creation of new Dao proposals and required tighter rules for threshold and duration.

Related Issues:

Checklist:

  • My change requires a change to the documentation and I have updated it accordingly
  • I have added tests to cover my changes.
  • My commits follow this conventional commits guide.

@sameh-farouk sameh-farouk marked this pull request as draft June 3, 2024 14:12
Copy link
Contributor

@renauter renauter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!
See my suggestions

@sameh-farouk sameh-farouk marked this pull request as ready for review June 3, 2024 15:46
@sameh-farouk sameh-farouk marked this pull request as draft June 3, 2024 15:46
@sameh-farouk sameh-farouk marked this pull request as ready for review June 3, 2024 16:12
Copy link
Contributor

@renauter renauter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sameh-farouk sameh-farouk merged commit 8a36c1d into development Jun 5, 2024
1 check passed
@renauter renauter deleted the development-fix-dao-min-threshold-and-duration branch June 5, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants