Skip to content

Support DEX orders on stellar client #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AhmedHanafy725 opened this issue Nov 25, 2024 · 9 comments
Open

Support DEX orders on stellar client #112

AhmedHanafy725 opened this issue Nov 25, 2024 · 9 comments
Assignees
@AlaaElattar
Labels
feature
Milestone
1.1.0

Comments

@AhmedHanafy725
Copy link
Contributor

Which package/s are you suggesting this feature for?

stellar_client

Is your feature request related to a problem? Please describe

threefoldtech/threefold_connect#775

Describe the solution you'd like

support placing, canceling, and listing orders
@ramezsaeed ramezsaeed added this to the 1.1.0 milestone Nov 26, 2024
@ramezsaeed ramezsaeed moved this to Accepted in 3.16.x Nov 26, 2024
@AlaaElattar AlaaElattar moved this from Accepted to In Progress in 3.16.x Nov 28, 2024
@AlaaElattar AlaaElattar self-assigned this Nov 28, 2024
@AlaaElattar AlaaElattar mentioned this issue Dec 5, 2024
Merged
4 tasks
@AlaaElattar
Copy link
Contributor

Work in progress

  • all done except that submitting any order not working with threefold service so still debugging in it.

@AlaaElattar AlaaElattar moved this from In Progress to Blocked in 3.16.x Dec 9, 2024
@AlaaElattar
Copy link
Contributor

Blocked

  • couldn't get any info about how to use TF service with creating/cancelling orders, only supported that user should have xlms to make any orders.

@AlaaElattar AlaaElattar moved this from Blocked to In Progress in 3.16.x Feb 9, 2025
@AlaaElattar
Copy link
Contributor

Work In Progress:

  • Adding docs to each function and its requirements for more explanation.
  • Fixing pr comments

@AlaaElattar
Copy link
Contributor

Work Completed:

  • Added documentation for functions explaining all details.
  • Added _getAsset to remove duplicated code across functions.

@AlaaElattar AlaaElattar moved this from In Progress to Pending Review in 3.16.x Feb 18, 2025
@AlaaElattar
Copy link
Contributor

Work Completed:

  • Updated docs about stellar representation of orders.

@AlaaElattar AlaaElattar moved this from Pending Review to In Progress in 3.16.x Mar 10, 2025
@AlaaElattar
Copy link
Contributor

Work Completed:

  • Added getTradingHistory method.

@AlaaElattar AlaaElattar moved this from In Progress to Pending Review in 3.16.x Mar 10, 2025
@AlaaElattar AlaaElattar moved this from Pending Review to In Progress in 3.16.x Mar 12, 2025
@AlaaElattar
Copy link
Contributor

Work Completed:

  • Updated createOrder, updateOrder and cancelOrder functions to return boolean.

@AlaaElattar
Copy link
Contributor

Work Completed:

  • Applied pr comments.

@AlaaElattar AlaaElattar moved this from In Progress to Pending Review in 3.16.x Apr 28, 2025
@AlaaElattar AlaaElattar moved this from Pending Review to In Progress in 3.16.x Apr 30, 2025
@AlaaElattar AlaaElattar moved this from In Progress to Pending Review in 3.16.x Apr 30, 2025
@AlaaElattar
Copy link
Contributor

Work Complete:

  • Applied pr comments.

@AlaaElattar AlaaElattar moved this from Pending Review to Pending Deployment in 3.16.x May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlaaElattar AlaaElattar

Labels
feature
Projects
3.16.x
Status: Pending Deployment
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@ramezsaeed @AhmedHanafy725 @AlaaElattar