Skip to content

Upgrade polkadart #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025
Merged

Upgrade polkadart #152

merged 3 commits into from
May 12, 2025

Conversation

zaelgohary
Copy link
Collaborator

@zaelgohary zaelgohary commented May 10, 2025

Description

  • Upgraded Polkadart and dependencies (signer, tfchain).
  • Addressed issues arising from the upgrade, including generating new pallets.
  • Refactored QueryClient.connect for improved connection handling:
    • Added checks for incomplete connection entries in the static map.
    • Explicitly created new WsProvider instances with autoConnect: false for controlled connection initiation.
    • Standardized connection error handling with proper cleanup on failure.
    • Ensure the provider is ready for RPC communication, along with error handling for readiness failures.

Related Issues

Checklist

  • Tests included
  • Build pass
  • Code format
  • Screenshots/Video attached (needed for UI changes)

… issue, produce new palletes, edit tfchain connect method
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2025

Codecov Report

Attention: Patch coverage is 52.94118% with 16 lines in your changes missing coverage. Please review.

Project coverage is 63.36%. Comparing base (faf00a8) to head (25689c5).
Report is 1 commits behind head on development.

Files with missing lines Patch % Lines
packages/tfchain_client/lib/src/client.dart 50.00% 15 Missing ⚠️
packages/tfchain_client/test/setup_manager.dart 66.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #152      +/-   ##
===============================================
+ Coverage        63.12%   63.36%   +0.23%     
===============================================
  Files               26       26              
  Lines             1177     1201      +24     
===============================================
+ Hits               743      761      +18     
- Misses             434      440       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zaelgohary zaelgohary requested a review from AhmedHanafy725 May 11, 2025 13:59
@zaelgohary zaelgohary merged commit 7f33a44 into development May 12, 2025
2 checks passed
@zaelgohary zaelgohary deleted the development_upgrade_polkadart branch May 12, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants