Add Workflows #8
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
|
do we need to keep the coverage directory uploaded? |
…into main_signer_workflows
.github/workflows/build.yaml
Outdated
| name: Build | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
please add on push on the main branch too.
.github/workflows/build.yaml
Outdated
There was a problem hiding this comment.
the file name is called build while it doesn't build the code. maybe call it analyze
.github/workflows/build.yaml
Outdated
| - name: Install dependencies | ||
| run: dart pub global run melos bootstrap | ||
|
|
||
| - name: Linting |
There was a problem hiding this comment.
| - name: Linting | |
| - name: Analyze |
| on: | ||
| pull_request: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
same here add on pushing on the main branch.
| run: | | ||
| melos exec rm -rf coverage | ||
| melos run unit_test | ||
| melos exec --dir-exists="coverage" -- bash -c 'dart pub global run coverde filter --input coverage/lcov.info --output coverage/filtered.lcov.info --filters .g.dart' |
There was a problem hiding this comment.
please split running the tests and calculating the coverage into 2 different steps. the coverage step should check if the tests passed successfully to run.
| melos exec --dir-exists="coverage" -- bash -c 'dart pub global run coverde value -i coverage/filtered.lcov.info > coverage/result.txt' | ||
|
|
||
| - name: Upload coverage to Codecov | ||
| uses: codecov/codecov-action@v3 |
There was a problem hiding this comment.
this step should check if the coverage step is finished without errors
.github/workflows/tests.yaml
Outdated
There was a problem hiding this comment.
this workflow is a duplicate of the coverage workflow. let's remove it
No description provided.