fix version update

Author: Eslam-Nawara

node-registrar/pkg/db/version.go

@@ -2,11 +2,12 @@ package db
 
 import (
 	"errors"
-	"reflect"
 
 	"gorm.io/gorm"
 )
 
+const zos4Key = "zos_4"
+
 func (db *Database) SetZOSVersion(version ZosVersion) error {
 	var current ZosVersion
 	result := db.gormDB.Where(ZosVersion{Key: ZOS4VersionKey}).Attrs(ZosVersion{Version: version.Version}).FirstOrCreate(&current)
@@ -16,18 +17,25 @@ func (db *Database) SetZOSVersion(version ZosVersion) error {
 	}
 
 	if result.RowsAffected == 0 {
-		if reflect.DeepEqual(current, version) {
+		update := map[string]any{}
+		if current.Version != version.Version {
+			update["version"] = version.Version
+		}
+		if current.SafeToUpgrade != version.SafeToUpgrade {
+			update["safe_to_upgrade"] = version.SafeToUpgrade
+		}
+		if len(update) == 0 {
 			return ErrVersionAlreadySet
 		}
 		return db.gormDB.Model(&current).
-			Select("version").
+			Where("key = ?", zos4Key).
 			Updates(version).Error
 	}
 	return nil
 }
 
 func (db *Database) GetZOSVersion() (version ZosVersion, err error) {
-	if err := db.gormDB.Where("key = ?", "zos_4").First(&version).Error; err != nil {
+	if err := db.gormDB.Where("key = ?", zos4Key).First(&version).Error; err != nil {
 		if errors.Is(err, gorm.ErrRecordNotFound) {
 			return version, ErrRecordNotFound
 		}