fix server not detecting conflicts on duplicated names #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslam-Nawara
requested review from
mariobassem,
ashraffouda,
rawdaGastan,
Omarabdul3ziz,
AbdelrahmanElawady,
xmonader and
sameh-farouk
as code owners
rawdaGastan
reviewed
Mar 12, 2025
| @@ -41,9 +43,10 @@ func (db *Database) GetFarm(farmID uint64) (farm Farm, err error) { | |||
|
|
|||
| func (db *Database) CreateFarm(farm Farm) (uint64, error) { | |||
| if err := db.gormDB.Create(&farm).Error; err != nil { | |||
| if errors.Is(err, gorm.ErrDuplicatedKey) { | |||
| if errors.Is(err, gorm.ErrDuplicatedKey) || strings.Contains(err.Error(), "23505") { | |||
There was a problem hiding this comment.
not sure if checking on the error code would be better
There was a problem hiding this comment.
tried to match against pq.ErrorCode but it didn't work so I matched strings
rawdaGastan
approved these changes
Mar 12, 2025
Eslam-Nawara
force-pushed
the
development-fix-farm-name-conflict
branch
2 times, most recently
from
0aa5c79 to
681a04a
Compare
Eslam-Nawara
force-pushed
the
development-fix-farm-name-conflict
branch
from
681a04a to
421cb93
Compare
Eslam-Nawara
force-pushed
the
development-fix-farm-name-conflict
branch
from
7ca3232 to
c164805
Compare
rawdaGastan
approved these changes
Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix server not detecting conflicts on duplicated names
Related Issues
List of related issues
Checklist