add node registrar client #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslam-Nawara
force-pushed
the
development-add-node-registrar-client
branch
from
45455c2 to
7ceeea7
Compare
Eslam-Nawara
requested review from
mariobassem,
ashraffouda,
rawdaGastan,
Omarabdul3ziz,
AbdelrahmanElawady,
xmonader and
sameh-farouk
as code owners
Eslam-Nawara
force-pushed
the
development-add-node-registrar-client
branch
5 times, most recently
from
c27651f to
c74f8eb
Compare
ashraffouda
requested changes
Mar 6, 2025
| return errors.Wrap(err, "failed to parse request body") | ||
| } | ||
|
|
||
| req, err := http.NewRequest("PATCH", url, &body) |
There was a problem hiding this comment.
why using patch here? we r updating one account
There was a problem hiding this comment.
patch method in http request is used for making partial changes to an existing resource.
| } | ||
|
|
||
| func (c *RegistrarClient) updateAccount(opts []UpdateAccountOpts) (err error) { | ||
| err = c.ensureTwinID() |
There was a problem hiding this comment.
ensure account creates account if it doesn't exist, while i believe update on none existing account should fail
There was a problem hiding this comment.
this function call here is ensureTwin not ensureAccount, it ensures that the registrar client is set up probably with a valid account, it doesn't create account if not exist.
* support mnemonics in registrar client * fix drive keys from seed * update registrar client readme file * remove extra print lines * remove extra comments * lower case error messages
Eslam-Nawara
force-pushed
the
development-add-node-registrar-client
branch
from
9d8b469 to
7908c98
Compare
Eslam-Nawara
force-pushed
the
development-add-node-registrar-client
branch
from
513a105 to
3eb0fb7
Compare
rawdaGastan
reviewed
Mar 11, 2025
node-registrar/client/account.go
Outdated
|
|
||
| data := map[string]any{ | ||
| "public_key": c.keyPair.Public(), | ||
| "signature": signature, |
There was a problem hiding this comment.
shouldn't signature be encoded in base64?
ashraffouda
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add node registrar client
Changes
List of changes this PR includes
Related Issues
Checklist