Development registrar client #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

SalmaElsoly merged 25 commits into development from development_registrar_client

Mar 17, 2025

Contributor

SalmaElsoly commented Feb 18, 2025

Description

implemented client for registrar :

farm(create/list/get/update)
account(create/get by public key / get by twin id / update)
node(register/list/get/update/ report uptime)
zos(get version)

Setup monorepo

used yarn with lerna + prettier + eslint

Related issues

#2 (comment)
#1 (comment)

SalmaElsoly added 6 commits

February 17, 2025 15:55


          implement account, farm, node services for registrar

381fc7c


          refactor to take private key in the intilization of the client

3010a97


          fix return type of farm creation + add error handling in config

56136ee


          add integration tests

41a10fb


          add intial README

5f5f17f


          configure eslint

b737d50

xmonader reviewed

View reviewed changes

packages/registrar_client/src/client/client.ts Outdated Show resolved Hide resolved

xmonader reviewed

View reviewed changes

packages/registrar_client/README.md Outdated Show resolved Hide resolved

xmonader reviewed

View reviewed changes

packages/registrar_client/README.md Show resolved Hide resolved

xmonader reviewed

View reviewed changes

packages/registrar_client/package.json Outdated Show resolved Hide resolved

xmonader reviewed

View reviewed changes

packages/registrar_client/src/modules/account/service.ts Outdated Show resolved Hide resolved

xmonader reviewed

View reviewed changes

packages/registrar_client/src/config.ts Outdated Show resolved Hide resolved

xmonader reviewed

View reviewed changes

packages/registrar_client/src/modules/account/service.ts Outdated Show resolved Hide resolved

xmonader reviewed

View reviewed changes

packages/registrar_client/src/modules/account/service.ts Outdated Show resolved Hide resolved


          add utils for signature and auth header + add keyed parameters to client

a546fa6

SalmaElsoly force-pushed the development_registrar_client branch from 0f24159 to a546fa6 Compare

February 18, 2025 13:34

SalmaElsoly requested a review from xmonader

February 18, 2025 13:35

SalmaElsoly added 3 commits

February 19, 2025 16:15


          fix json writing convention

809aa51


          update repo README

397ab7f


          adjust package exports

10f5896

0oM4R reviewed

View reviewed changes

0oM4R left a comment

Great work ya Salma 👏

I have some suggestions :

I think we are going to use the module types in other places in the project rather than the module itself; IMO it's better to have an outer directory for types
we need some extra info about how to start the project what are the requirements how to build and how to run tests.

That was an overview of the code will test the functionality and comment back with the results.

packages/registrar_client/package.json Show resolved Hide resolved

packages/registrar_client/README.md Show resolved Hide resolved

packages/registrar_client/src/modules/account/service.ts Outdated Show resolved Hide resolved

packages/registrar_client/src/modules/farm/service.ts Outdated Show resolved Hide resolved

packages/registrar_client/tests/integration_tests/farm.spec.ts Show resolved Hide resolved

packages/registrar_client/src/modules/node/service.ts Outdated Show resolved Hide resolved

packages/registrar_client/tests/integration_tests/node.spec.ts Outdated Show resolved Hide resolved

packages/registrar_client/src/utils.ts Outdated Show resolved Hide resolved

packages/registrar_client/tsconfig.json Outdated Show resolved Hide resolved


          update dirs structure + use latest js + update package.json

fc8e8a0

SalmaElsoly force-pushed the development_registrar_client branch from affd109 to 605877a Compare

February 27, 2025 09:57


          add more tests and validation for node data

232d833

SalmaElsoly force-pushed the development_registrar_client branch from 605877a to 232d833 Compare

February 27, 2025 09:57

SalmaElsoly added 3 commits

February 27, 2025 16:46


          add scripts for usage

db36618


          update README

bec1da1


          skip failed tests because of server bug

4664bac

Contributor Author

SalmaElsoly commented Feb 27, 2025

Great work ya Salma 👏

I have some suggestions :

I think we are going to use the module types in other places in the project rather than the module itself; IMO it's better to have an outer directory for types

we need some extra info about how to start the project what are the requirements how to build and how to run tests.

That was an overview of the code will test the functionality and comment back with the results.

Thanks! I've addressed almost all the suggestions and comments.

SalmaElsoly requested a review from 0oM4R

February 27, 2025 16:21


          update scripts to use config.json + update yarn version

0d30268

SalmaElsoly force-pushed the development_registrar_client branch from 1acfd65 to 0d30268 Compare

March 4, 2025 08:44

SalmaElsoly requested a review from 0oM4R

March 4, 2025 08:50


          update declarations in tsconfig

0443d0c

0oM4R reviewed

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

0oM4R reviewed

View reviewed changes

packages/registrar_client/package.json Show resolved Hide resolved


          updates tests to config.json + fix build module types

1b6ab88

SalmaElsoly force-pushed the development_registrar_client branch from 960dd1c to 1b6ab88 Compare

March 4, 2025 14:47


          fix uri

79df76d

0oM4R reviewed

View reviewed changes

packages/registrar_client/package.json Show resolved Hide resolved

0oM4R reviewed

View reviewed changes

0oM4R left a comment

The test keeps failing with me against https://registrar.dev4.grid.tf/v1

SalmaElsoly added 2 commits

March 10, 2025 12:28


          support stellar address in farm creation and update + fix tests

1e321b4


          update scripts + fix package.json

142087d

SalmaElsoly force-pushed the development_registrar_client branch from 8088dcc to 8ad4c7b Compare

March 10, 2025 11:16


          disable workspace in pkg.json

6b287e9

SalmaElsoly force-pushed the development_registrar_client branch from 8ad4c7b to 6b287e9 Compare

March 10, 2025 11:39

0oM4R reviewed

View reviewed changes

packages/registrar_client/scripts/README.md Outdated Show resolved Hide resolved


          update readme

f4d8f84

SalmaElsoly requested a review from 0oM4R

March 10, 2025 13:57

0oM4R reviewed

View reviewed changes

0oM4R left a comment

Some tiny enhncments,
also please update readmes to include the new added staller address

packages/registrar_client/scripts/update_farm.ts Outdated Show resolved Hide resolved

packages/registrar_client/scripts/create_farm.ts Outdated Show resolved Hide resolved

packages/registrar_client/scripts/create_node.ts Outdated Show resolved Hide resolved

SalmaElsoly requested a review from 0oM4R

March 11, 2025 10:20

SalmaElsoly marked this pull request as draft

March 11, 2025 11:17


          fix scripts + update readme

1e4e107

SalmaElsoly force-pushed the development_registrar_client branch from e01e519 to 2674243 Compare

March 11, 2025 12:13

SalmaElsoly marked this pull request as ready for review

March 12, 2025 10:52

0oM4R approved these changes

View reviewed changes

0oM4R left a comment

thank you Salma

packages/registrar_client/scripts/README.md Outdated Show resolved Hide resolved


          fix requests timeout

0bab692

SalmaElsoly force-pushed the development_registrar_client branch from 2674243 to 0bab692 Compare

March 17, 2025 08:37

SalmaElsoly merged commit 84ee6df into development

SalmaElsoly deleted the development_registrar_client branch

March 17, 2025 08:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet