Skip to content

Development support mnemonics in registrar client #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2025

Conversation

SalmaElsoly
Copy link
Contributor

Changes:

  • use mnemonics or seed instead of private key

Related issues:

#8

Copy link

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a user I should be able to select a keypair type while instantiating the client object.

@SalmaElsoly SalmaElsoly requested a review from AhmedHanafy725 May 5, 2025 08:33
Copy link

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

2 tests fail when running yarn test, can you check them?

@SalmaElsoly SalmaElsoly requested a review from AhmedHanafy725 May 5, 2025 13:07
@SalmaElsoly SalmaElsoly merged commit f06463f into development May 6, 2025
@SalmaElsoly SalmaElsoly deleted the development_mnemonics_registrar branch May 6, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants