Support v4 farms

[AhmedHanafy725]

• Add v3 & v4 tabs at the top on the same farming screen.
• The UI should be the same.

[zaelgohary]

WIP:

Changed farms screen layout to include 2 tabs, v3 & v4. Also, added registrar service.

[zaelgohary]

Blocked on dart registrar client to be ready.

[zaelgohary]

WIP:

I added two listing functions: one for v3 farms and another for v4 farms. However, I'm unsure how to connect wallets before listing v4 farms. @AhmedHanafy725 suggested creating a registrar account only when a farm is created. However, I’m still uncertain about the listing process if no account is found. (Listing happens in initState)

Should I create an account for each wallet before listing? Shouldn't users be informed of the difference between v3 & v4 farms? Also, shouldn’t users be informed about the account creation process?

[zaelgohary]

WIP:

Removed register service, added listV3 & listV4 farms + generateKeypair, Fixed listFarmsWidget if farms are empty, added farm depending on the active tab. Currently working on changing farm details UI depending on the farm type.

[zaelgohary]

WIP:

Fixed listing wallets, and addFarm dialogue overflow. There was an issue with generating keys from mnemonics so I fixed that too. Added create registrar account & v4 farm logic but I'm stuck as it always gives me 404 whenever I try to create an account. I fixed some issues related to conflicts in farm types, too.

[mik-tf]

Amazing work. Is there a current APK with this feature? If possible, let me know where to download it. Then I can test it on V4 nodes myself and with v4 node vendors.

@xmonader @zaelgohary @AhmedHanafy725

Any way we can release this within the next 10 days on the app + google stores? We promised customers on 12.12 that nodes would be shipped before the end of Q1. This gives us a couple of weeks. Thanks!

[zaelgohary]

WIP:

I successfully created a farm and was able to list it, However, when I tried to create another farm with the same wallet I faced multiple errors. Also, fixed mixed types (differences between v3 & v4 farm). but faced the same issue while trying to list v4 farms again. Still looking into it.

Also, checked the key generation used in the client and in the registrar to match the generation from the app. (Should use lib sodium in generating keys in case mnemonic seed instead of bip39)

[zaelgohary]

Fixed the mismatch error. I forgot to change the v4 farm type before populating the farm item widget. Also, found a bug where a new farm object is being added to farms even if sth wrong happened. Fixed that too. Conditioned creating farm only if account is not null.

The PR is ready to be tested; however, the stellar address field is still missing from the registrar and its dart client & the nodes field never updates. I'm currently working on refactoring my code, but once I'm done, I should be blocked on that.

[zaelgohary]

Work Completed:

Did some refactoring in the PR. Also, applied stellar changes in dart client and the app.

[zaelgohary]

Fixed v4 farm name verification and replaced polling wallets in farms w stream listener in provider itself. Fixed some other bugs too.

[mik-tf]

Amazing thanks for the work and the release on time!

[khaledyoussef24]

verified version 4.2.0 IOS
user now can create V4 farms using threefold connect app

testcase 1
testcase 2
testcase 3
testcase 4

[mik-tf]

The app is updated on the stores. I could create a farm. Great.

What is the logic with the Stellar wallet here? V4 isn't linked to Stellar.

[AhmedHanafy725]

What is the logic with the Stellar wallet here? V4 isn't linked to Stellar.

added for future use in case we need it

[mik-tf]

OK I understand that. The situation is that V4 won't be on Stellar so the address on Stellar is not relevant here and can be misleading for farmers.

Can we set the farm creation v4 to be without a wallet and then farmers can add a wallet later, e.g. when we decided on the blockchain and then farmers can select that blockchain wallet? We can see what's best for what's to come.