check for error of type ActivationServiceError

Author: Eslam-Nawara

pkg/substrate_gateway/substrate_gateway.go

@@ -57,14 +57,14 @@ func (g *substrateGateway) EnsureAccount(activationURL []string, termsAndConditi
 		Msg("method called")
 	g.mu.Lock()
 	defer g.mu.Unlock()
+
 	for _, url := range activationURL {
 		info, err = g.sub.EnsureAccount(g.identity, url, termsAndConditionsLink, termsAndConditionsHash)
 		// check other activationURL only if EnsureAccount failed with ActivationServiceError
-		if errors.Is(err, substrate.ActivationServiceError{}) {
-			log.Debug().Str("activation url", url).Err(err).Msg("failed to EnsureAccount with ActivationServiceError")
-			continue
+		if err == nil || !errors.As(err, &substrate.ActivationServiceError{}) {
+			return
 		}
-		return
+		log.Debug().Str("activation url", url).Err(err).Msg("failed to EnsureAccount with ActivationServiceError")
 	}
 	return
 }