update geoip tests

Author: Eslam-Nawara

go.mod

@@ -39,7 +39,6 @@ require (
 	github.com/joncrlsn/dque v0.0.0-20200702023911-3e80e3146ce5
 	github.com/lestrrat-go/jwx v1.1.7
 	github.com/machinebox/graphql v0.2.2
-	github.com/oasisprotocol/curve25519-voi v0.0.0-20230904125328-1f23a7beb09a
 	github.com/opencontainers/runtime-spec v1.0.3-0.20210326190908-1c3f411f0417
 	github.com/patrickmn/go-cache v2.1.0+incompatible
 	github.com/pkg/errors v0.9.1

pkg/geoip/README.md

@@ -1,6 +1,6 @@
 # Geoip Module
 
-The `geoip` module provides a simple way to determine the geographical location of an IPv4 or IPv6 address.
+The `geoip` module provides a simple way to determine the geographical location of the system executing the code.
 This includes details such as longitude, latitude, country, city, and continent.
 
 ## Features

pkg/geoip/geoip.go

@@ -29,7 +29,6 @@ var (
 
 // Fetch retrieves the location of the system calling this function
 func Fetch() (Location, error) {
-
 	for _, url := range geoipURLs {
 		l, err := getLocation(url)
 		if err != nil {

pkg/geoip/geoip_test.go

@@ -5,75 +5,66 @@ import (
 	"testing"
 
 	"github.com/jarcoal/httpmock"
-	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
-func Test_getLocation(t *testing.T) {
+func TestGetLocation(t *testing.T) {
 	httpmock.Activate()
 	defer httpmock.DeactivateAndReset()
 
-	t.Run("running correct response", func(t *testing.T) {
-		for i := 0; i < len(geoipURLs); i++ {
-			httpmock.RegisterResponder("GET", geoipURLs[i],
+	require := require.New(t)
+
+	t.Run("test valid response", func(t *testing.T) {
+		l := Location{
+			Continent: "Africa",
+			Country:   "Egypt",
+			City:      "Cairo",
+		}
+
+		for _, url := range geoipURLs {
+			httpmock.RegisterResponder("GET", url,
 				func(req *http.Request) (*http.Response, error) {
-					l := Location{
-						Continent: "Africa",
-						Country:   "Egypt",
-						City:      "Cairo",
-					}
-					resp, err := httpmock.NewJsonResponse(200, l)
-					return resp, err
+					return httpmock.NewJsonResponse(200, l)
 				},
 			)
-			value, err := getLocation(geoipURLs[i])
-			assert.Equal(t, nil, err)
-			assert.Equal(t, "Egypt", value.Country)
-			assert.Equal(t, "Africa", value.Continent)
-			assert.Equal(t, "Cairo", value.City)
-			if err != nil {
-				t.Errorf("got %v", err)
-			}
+
+			resp, err := getLocation(url)
+			require.NoError(err)
+			require.Equal(resp, l)
 		}
 	})
 
-	t.Run("asserting wrong response code", func(t *testing.T) {
-		for i := 0; i < len(geoipURLs); i++ {
-			httpmock.RegisterResponder("GET", geoipURLs[i],
+	l := Location{
+		Continent: "Unknown",
+		Country:   "Unknown",
+		City:      "Unknown",
+	}
+
+	t.Run("test 404 status code", func(t *testing.T) {
+		for _, url := range geoipURLs {
+			httpmock.RegisterResponder("GET", url,
 				func(req *http.Request) (*http.Response, error) {
-					l := Location{
-						Continent: "Africa",
-						Country:   "Egypt",
-						City:      "Cairo",
-					}
-					resp, err := httpmock.NewJsonResponse(404, l)
-					return resp, err
+					return httpmock.NewJsonResponse(404, l)
 				},
 			)
-			value, err := getLocation(geoipURLs[i])
-			assert.NotEqual(t, err, nil)
-			assert.Equal(t, "Unknown", value.Country)
-			assert.Equal(t, "Unknown", value.Continent)
-			assert.Equal(t, "Unknown", value.City)
+
+			resp, err := getLocation(url)
+			require.Error(err)
+			require.Equal(resp, l)
 		}
 	})
 
-	t.Run("asserting sending wrong response data", func(t *testing.T) {
-		for i := 0; i < len(geoipURLs); i++ {
-			httpmock.RegisterResponder("GET", geoipURLs[i],
+	t.Run("test invalid response data", func(t *testing.T) {
+		for _, url := range geoipURLs {
+			httpmock.RegisterResponder("GET", url,
 				func(req *http.Request) (*http.Response, error) {
-					l := Location{
-						City: "Cairo",
-					}
-					resp, err := httpmock.NewJsonResponse(200, l.City)
+					resp, err := httpmock.NewJsonResponse(200, "Cairo")
 					return resp, err
 				},
 			)
-			value, err := getLocation(geoipURLs[i])
-			assert.NotEqual(t, err, nil)
-			assert.Equal(t, "Unknown", value.Country)
-			assert.Equal(t, "Unknown", value.Continent)
-			assert.Equal(t, "Unknown", value.City)
+			resp, err := getLocation(url)
+			require.Error(err)
+			require.Equal(resp, l)
 		}
 	})
-
 }