Use registrar client #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslam-Nawara
requested review from
muhamadazmy,
Omarabdul3ziz,
ashraffouda,
rawdaGastan and
xmonader
as code owners
Eslam-Nawara
force-pushed
the
use-registrar-client
branch
from
74d23a5 to
3d95463
Compare
rawdaGastan
requested changes
Mar 3, 2025
|
|
||
| r.mu.Lock() | ||
| defer r.mu.Unlock() | ||
| opts := []client.UpdateNodeOpts{ |
There was a problem hiding this comment.
are those updates required?
There was a problem hiding this comment.
don't understand what you mean by are updates required
| } | ||
|
|
||
| func (r *registrarGateway) GetTime() (time.Time, error) { | ||
| // log.Trace().Str("method", "Time").Msg("method called") |
There was a problem hiding this comment.
this is not implemented in the registrar yet
|
|
||
| nodeID, regErr := registrarGateway.GetNodeByTwinID(ctx, twinID) | ||
| node, regErr := registrarGateway.GetNodeByTwinID(ctx, twinID) | ||
| nodeID = node.NodeID |
There was a problem hiding this comment.
how could we retrieve the node ID if there is an error?
There was a problem hiding this comment.
if there's an error it would create a node if the error is ErrorNodeNotFound, if not it will fail
pkg/registrar_light/register.go
Outdated
| if regErr != nil { | ||
| if strings.Contains(regErr.Error(), registrargw.ErrorRecordNotFound.Error()) { | ||
| nodeID, err = registrarGateway.CreateNode(ctx, req) | ||
| if strings.Contains(regErr.Error(), client.ErrorNodeNotFround.Error()) { |
There was a problem hiding this comment.
cannot we use errors.As?
There was a problem hiding this comment.
tried it and it's not working
| } | ||
|
|
||
| // if we are on devnet just update we don't need to update the version throught out the registrar | ||
| v := "v0.0.0" | ||
| v := client.ZosVersion{Version: "v0.0.0", SafeToUpgrade: true} |
There was a problem hiding this comment.
why setting version to zero?
There was a problem hiding this comment.
this was already the flow, I just updated how it stored
|
blocked on threefoldtech/zosbase#16 |
4 tasks
Eslam-Nawara
force-pushed
the
use-registrar-client
branch
2 times, most recently
from
0d23bba to
442bed7
Compare
Eslam-Nawara
force-pushed
the
use-registrar-client
branch
2 times, most recently
from
c378623 to
345e18c
Compare
Eslam-Nawara
force-pushed
the
use-registrar-client
branch
from
345e18c to
0a0d2a0
Compare
Eslam-Nawara
force-pushed
the
use-registrar-client
branch
2 times, most recently
from
2a428a8 to
212bc90
Compare
Eslam-Nawara
force-pushed
the
use-registrar-client
branch
from
212bc90 to
4942d23
Compare
ashraffouda
requested changes
May 6, 2025
ashraffouda
approved these changes
May 6, 2025
Eslam-Nawara
force-pushed
the
use-registrar-client
branch
from
7031a12 to
4725133
Compare
Eslam-Nawara
force-pushed
the
use-registrar-client
branch
from
4725133 to
d813867
Compare
ashraffouda
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update registrar gateway to use the new registrar client
Changes
List of changes this PR includes
Related Issues
Checklist