Skip to content

Commit b3c24a7

Browse files
Merge pull request #2329 from keep-network/actions-go-build-branch-filter
Run Go workflow only on `rfc-18/**` branches We restricted branches for which Go build and test workflow gets executed. Currently execution duplicates with workflow executed in CircleCI. We defined rfc-18/ prefix. For branches with that prefix, jobs will be executed in GH Actions instead of Circle CI.
2 parents 61f9bb7 + 45ae3a8 commit b3c24a7

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

.circleci/config.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,9 @@ workflows:
337337
- build_client_and_test_go:
338338
filters:
339339
branches:
340-
ignore: master
340+
ignore:
341+
- master
342+
- /rfc-18\/.*/
341343
context: keep-dev
342344
- build_token_dashboard_dapp:
343345
filters:

.github/workflows/client.yml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,16 @@
11
name: Go
22

3-
#TODO: extend the conditions once workflow gets tested together with other workflows
4-
on:
3+
#TODO: extend the conditions once workflow gets tested together with other workflows
4+
on:
55
push:
66
branches:
7-
- master
7+
# TODO: Run on master after we're fully migrated from Circle CI
8+
# - master
9+
- "rfc-18/**"
810
pull_request:
11+
branches:
12+
# TODO: Run on all branches after we're fully migrated from Circle CI
13+
- "rfc-18/**"
914
workflow_dispatch:
1015

1116
jobs:
@@ -21,7 +26,7 @@ jobs:
2126
--target gobuild \
2227
--tag go-build-env .
2328
docker build \
24-
--tag keep-client .
29+
--tag keep-client .
2530
- name: Create test results directory
2631
run: |
2732
mkdir test-results
@@ -37,6 +42,6 @@ jobs:
3742
if: always() # guarantees that this action always runs, even if earlier steps fail
3843
with:
3944
github_token: ${{ secrets.GITHUB_TOKEN }}
40-
files: ./test-results/unit-tests.xml
45+
files: ./test-results/unit-tests.xml
4146
check_name: Go Test Results # name under which test results will be presented in GitHub (optional)
4247
comment_on_pr: false # turns off commenting on Pull Requests

0 commit comments

Comments
 (0)