Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oauth updates #28

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Oauth updates #28

wants to merge 14 commits into from

Conversation

gwbischof
Copy link
Contributor

@gwbischof gwbischof commented Nov 15, 2024

There are a good amount of updates to the lemmy v0.20.0 API. This PR fixes the ones that are required to run with v0.20.0 and to support OAuth/SSO. There may be additional api changes also.

LemmyNet/lemmy@0.19.6...main
LemmyNet/lemmy-js-client@0.19.6...0.20.0-alpha.18

Some v0.20.0 api changes that I see so far:

  • SSO support
  • remove local_site.enableNsfw
  • remove local_site.enableDownvotes
  • remove local_user.defaultSortType
  • remove local_user.showScores
  • add local_user.defaultCommentSortType
  • add local_user.defaultPostSortType

I am following this blog post from @privacyguard to implement the SSO
https://privacyportal.org/blog/sign-in-with-privacy-portal-tutorial

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting work on the v0.20.x changes! I just made a quick comment for how to approach any newly added values in the API. Let me know if you need further guidance on adding/removing fields.

@gwbischof gwbischof changed the title V0.20.0 Oauth updates Jan 7, 2025
@gwbischof gwbischof marked this pull request as ready for review January 7, 2025 01:16
@hjiangsu
Copy link
Member

I just committed a couple of things:

  • Updated this PR to resolve conflicts with the master branch (this was due to me updating some stuff with the repo)
  • Removed the .swp files that were included in the PR (I believe they were maybe added in by mistake?)

Aside from that, I believe this looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants