Add additional medium font scale option #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjiangsu
changed the title
micahmo
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
LGTM!
it's difficult to immediately tell the actual font scales as there is no visual feedback until you go back to the feed page - a nice feature to add in the future would be a preview of the font scale size from within the settings/bottom sheet modal
In #982 I had added the ability to specify a TextTheme for list picker items, if it helps!
|
I've added the scaling to the bottom sheet! Let me know what you think of this.
|
…/additional-font-scales
…/additional-font-scales
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds an additional font scale for "Medium". The medium font scale slots between base and large. Additional feedback is needed to tweak the value of this scale! Additionally, I've localized most of the strings in the "Theme" setting pages (with the exception of the accent colour names)
Right now, it's difficult to immediately tell the actual font scales as there is no visual feedback until you go back to the feed page - a nice feature to add in the future would be a preview of the font scale size from within the settings/bottom sheet modal.
Issue Being Fixed
Issue Number: Partially solves #657
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?