Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exit confirmation snackbar #1064

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Jan 18, 2024

Pull Request Description

This is a small PR which fixes an apparently recent regression where the exit confirmation snackbar would not appear (most likely due to all the scaffold changes we've made recently). I also tweaked the wording slightly because I have found it a bit confusing. 😊

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_f1C0KD1IOG.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 008ef6e into thunder-app:develop Jan 18, 2024
1 check passed
@micahmo micahmo deleted the fix/exit-confirmation branch January 18, 2024 19:51
@micahmo micahmo mentioned this pull request Jan 31, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants