Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: reorganization of files to their domain #1071

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Jan 19, 2024

Pull Request Description

This is yet another refactor PR. This PR mainly focuses on moving some files to their respective domains. This aim is to make the code structure a bit easier to navigate (and reduce the number of files store in utils directory). Let me know what you think of this!

In general:

  • Moved utils/comment.dart and utils/navigate_comment to comment/utils
  • Moved utils/navigate_instance to instance/utils
  • Moved utils/navigate_create_post and utils/navigate_post to post/utils
  • Moved utils/navigate_user to user/utils

In addition:

  • shared/hero was removed since its no longer being used anywhere
  • Added check for FlutterDisplayMode to only trigger on Android. This removes an error when first opening Thunder on iOS

Sidenote: I'll be doing this in stages, so that it's easier to manage. I would like to do this for other widgets (especially ones that are in the shared directory such as the comment_ related widgets)

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I like the structure!

@hjiangsu hjiangsu merged commit 1e04c6d into develop Jan 22, 2024
1 check passed
@hjiangsu hjiangsu deleted the refactor/reorganization branch January 22, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants