Oauth updates #1642
Oauth updates #1642
Conversation
gwbischof
force-pushed
the
oauth
branch
2 times, most recently
from
1c7bc51 to
1c40cb3
Compare
| @@ -527,3 +527,78 @@ void showInputDialog<T>({ | |||
| }), | |||
| ); | |||
| } | |||
|
|
|||
| /// Shows a dialog which takes input and offers suggestions | |||
| Future<String?> showBlockingInputDialog<T>({ | |||
There was a problem hiding this comment.
This seems pretty similar to showInputDialog. Is there any way to combine these?
There was a problem hiding this comment.
showInputDialog doesn't block, so it didn't work to display the dialog where you enter your username on your first oauth login. So I modified it to create showBlockingInputDialog. So yea, they are pretty similar. I think showInputDialog is used in one other place in the code, maybe we could make that one blocking also?
There was a problem hiding this comment.
By blocking, do you just mean that the user can't tap outside the dialog area or press back to cancel it?
Is it possible that we can just have a flag for whether it's blocking or not?
We do use the existing one in several places, all of which should continue to be cancelable by the user.
There was a problem hiding this comment.
By blocking I mean showBlockingInputDialog will wait for the user to click accept before running the code that follows it. So you can await showBlockingInputDialog and that doesn't work with showInputDialog
There was a problem hiding this comment.
I will investigate and see if I can parameterize showInputDialog
There was a problem hiding this comment.
Ahh ok I gotcha! In that case, I think it makes sense to transition showInputDialog into a awaitable method. Existing code that doesn't care to await can just not do that and let it run in the background. Let me know what you think.
There was a problem hiding this comment.
Yea, I think that makes sense. I can do that
Co-authored-by: William <sirwilliamthefirst@users.noreply.github.com>
Co-authored-by: William <sirwilliamthefirst@users.noreply.github.com>
…ng on getting thunderapp.dev callback working
|
I just pushed a small change which adds a heading above the OAuth providers (to make it clear what they are and that they're an alternative to non-SSO login), and I also added a little space between each provider.
|
Sounds good, the changes look good to me after a quick review, and I've already tested a previous implementation of this! However, I'm going to hold off on merging this in until v0.20.0 is closer to release, or at least until Lemmy's API changes are more stable (at the moment, it looks like there's still a lot of major changes to the API that we'll need to support eventually). This way, we can re-test the implementation closer to the next major release! |
Oauth updates.
This PR depends on thunder-app/lemmy_api_client#28
This can be tested against the lemmy instance at hopandzip.com which I deployed with the lemmy:main