Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated build workflow for Android #1656

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Jan 7, 2025

Pull Request Description

This PR adds a new GitHub workflow that automatically builds nightly/general release builds for Android. I've opted to only work on the automated Android build for now as iOS requires a bit more effort to get set up (in particular, I would need to generate new provisioning profiles and certificates to perform automatic builds)

With the Android automated builds, I'll also be able to (hopefully) finalize the requirements needed for F-Droid reproducible builds. Once this PR is merged and a new nightly is built, I'll be able to verify that the F-Droid build process works as intended.

The next step after automating Android builds is to generate a template release markdown file to automatically populate the release notes!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo
Copy link
Member

micahmo commented Jan 7, 2025

This is awesome!

@hjiangsu hjiangsu changed the title Add automated builds Add automated build workflow for Android Jan 9, 2025
@hjiangsu hjiangsu marked this pull request as ready for review January 9, 2025 22:51
@hjiangsu
Copy link
Member Author

hjiangsu commented Jan 9, 2025

@micahmo This is ready to be reviewed - if you could, please look over the workflow and let me know if there's something that I might be missing here as I'm not too familiar with GitHub actions/workflows!

I've also updated the PR description to provide a bit more details.

@micahmo
Copy link
Member

micahmo commented Jan 14, 2025

I would need to generate new provisioning profiles and certificates to perform automatic builds

I'm not sure if it helps at all, but remember that you can upload secrets to the repository (Settings > Secrets and variables > Actions) which can be consumed in the actions. Maybe that will help to reuse existing certificates and such?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I'm sure it will really help to simplify your process!

@hjiangsu
Copy link
Member Author

I'm not sure if it helps at all, but remember that you can upload secrets to the repository (Settings > Secrets and variables > Actions) which can be consumed in the actions. Maybe that will help to reuse existing certificates and such?

I'm doing this for the Android secrets! However, for iOS, there are a few certificates that are automatically managed by Xcode. This means that I would have to re-create those certificates and replace them first before I can add them into GitHub

@hjiangsu hjiangsu merged commit fbfc278 into develop Jan 14, 2025
1 check passed
@hjiangsu hjiangsu deleted the feat/build-workflow branch January 14, 2025 17:41
@micahmo
Copy link
Member

micahmo commented Jan 14, 2025

Gotcha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants