Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link images not respecting edge-to-edge option #1708

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Feb 20, 2025

Pull Request Description

This PR fixes a visual inconsistency where enabling edge-to-edge images would be correctly applied to image previews but not link previews.

On a side note, it might be worthwhile to refactor the media preview widgets as the logic is fairly difficult to follow!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Current Fixed
simulator_screenshot_807CC749-C341-44CD-A577-5272233BC609 simulator_screenshot_5B4526CB-052F-43BB-A9DB-EE66BD0F4192
simulator_screenshot_459F2592-ACA9-4ACA-A347-1F0FDE28A85A simulator_screenshot_C60E165F-687D-4A4F-A283-185B8A2082E5

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjiangsu hjiangsu merged commit 162290c into develop Feb 20, 2025
1 check passed
@hjiangsu hjiangsu deleted the fix/edge-to-edge-images branch February 20, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants