kernel: fix sometimes sucompat can not toggle by manager #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiann
approved these changes
Mar 1, 2025
selfmusing
pushed a commit
to selfmusing/USlenreK
that referenced
this pull request
Mar 1, 2025
When the manager is already running, if other programs / kernel toggle the sucompat enable status, The manager "Disable SU Compat" toggle button can not work, kmesg print "cmd enable su but no need to change." I think we should still return reply_ok when the syscall value is consistent with the kernel, which would fix the issue.
selfmusing
pushed a commit
to selfmusing/USlenreK
that referenced
this pull request
Mar 1, 2025
When the manager is already running, if other programs / kernel toggle the sucompat enable status, The manager "Disable SU Compat" toggle button can not work, kmesg print "cmd enable su but no need to change." I think we should still return reply_ok when the syscall value is consistent with the kernel, which would fix the issue.
backslashxx
pushed a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 1, 2025
When the manager is already running, if other programs / kernel toggle the sucompat enable status, The manager "Disable SU Compat" toggle button can not work, kmesg print "cmd enable su but no need to change." I think we should still return reply_ok when the syscall value is consistent with the kernel, which would fix the issue.
YumeMichi
added a commit
to YumeMichi/KernelSU
that referenced
this pull request
Mar 4, 2025
* 'main' of https://github.com/tiann/KernelSU: build(deps): bump the maven group across 1 directory with 5 updates (tiann#2485) website: fix minor typos (tiann#2482) Set KSU_APP_PROFILE_VER for shell (tiann#2481) kernel: fix sometimes sucompat can not toggle by manager (tiann#2484) Avoid popping back stack right after navigation (tiann#2477)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the manager is already running, if other programs / kernel toggle the sucompat enable status,
The manager "Disable SU Compat" toggle button can not work, kmesg print "cmd enable su but no need to change."
I think we should still return reply_ok when the syscall value is consistent with the kernel, which would fix the issue.