Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made clock published independently from time scale #248

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

szylis
Copy link
Contributor

@szylis szylis commented Jan 17, 2024

This PR changes the functionality of the /clock. To make the clock's publishing frequency independent of the time scale.

Previously:
At timescale set to 1.0; /clock publish at rate 100Hz; time difference between timestamps in messages equal to 10 ms;
At timescale set to 0.1; /clock publish at rate 10Hz; time difference between timestamps in messages equal to 10 ms;

New behavior:
At timescale 1.0 everything stays the same.
At timescale 0.1; /clock publish at rate 100Hz; time difference between timestamps in messages equal to 1ms;

Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mackierx111 mackierx111 merged commit 45cce7b into main Jan 22, 2024
1 of 2 checks passed
@mackierx111 mackierx111 deleted the feature/clock-timescale-independent branch January 22, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants