Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/timesource options #266

Merged
merged 13 commits into from
Feb 27, 2024
Merged

Feature/timesource options #266

merged 13 commits into from
Feb 27, 2024

Conversation

szylis
Copy link
Contributor

@szylis szylis commented Feb 14, 2024

Features included in this PR:

  • added the dotnet system time source - a time source where the time starts from an epoch time and is then updated as the simulation progresses.
  • added option for setting the selected time source type in the .json configuration file.
  • improvement of unity time source, to make it thread-safe.

@szylis szylis requested a review from mackierx111 February 14, 2024 13:55
mackierx111
mackierx111 requested changes Feb 26, 2024
View reviewed changes
Assets/AWSIM/Scenes/Main/AutowareSimulation/AutowareSimulation.cs Outdated
void CollectComponents()
{
// get time source selector
timeSourceSelector = FindObjectOfType<TimeSourceSelector>();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using FindObjectOfType, could you please add a [SerializeField] TimeSourceSelector to AutowareSimulation.cs?
I would like to avoid type find at runtime as much as possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I've just made the change. Thanks

@mackierx111
Copy link
Collaborator

mackierx111 commented Feb 26, 2024 •
edited
Loading

Thanks for implementing this! I think it's good.
I made one comment.

mackierx111
mackierx111 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mackierx111 mackierx111 merged commit a60dc6b into main Feb 27, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mackierx111 mackierx111 mackierx111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szylis @mackierx111