Add C1 C2 prefabs, and camera featues

[lchojnack]

List of changes:

• Add C1 and C2 camera prefabs
• Change the thread group for RosImageShader
• Add Camera features:
  • Image adjustments
    • Hue
    • Color Saturation
    • Contrast
    • Brightness
    • Sharpness
  • Exposure settings
    • Auto Exposure
    • ISO
    • Shutter Speed
    • Aperture
  • Lens Distortion Correction
  • Additional Camera Effects available in Unity
    • Bloom
    • Chromatic Aberration
    • Depth of Field
    • Motion Blur

[mackierx111]

@lchojnack

I have merged the main branch into the feature/c1_c2_cameras branch in my local environment and got an error. can you please merge the main branch and resolve the error?

[szylis]

@mackierx111 and @lchojnack

I've updated branch to main one and I've added missing rendering pipeline references to AWSIM assembly. The errors should be gone now.

[mackierx111]

@lchojnack @szylis
Thanks for the implementation. Including a chart or checkerboard image for testing is a good idea.

I have some questions.

• Is it correct that the main purpose is to reproduce C1 and C2 cameras using volume profiles and HDAddtionalCameraData component?
• Am I correct that CameraSensorFeatureManager is a class that sets HDAddtionalCameraData and Volume/VolumeProfile from a script?
  • Is there a problem with setting HDAddtionalCameraData and Volume/VolumeProfile without CameraSensorFeatureManager?
• What are your thoughts on integrating the CameraSensorFeatureManager and CameraSensor classes?
• Can you please add documentation on the C1, C2 camera or this camera implementation?

[mackierx111]

MEMO: Also, if we adopt URP in AWSIM, these camera functions will be affected.

[lchojnack]

@mackierx111

Is it correct that the main purpose is to reproduce C1 and C2 cameras using volume profiles and HDAddtionalCameraData component?

The main purpose is to implement C1 and C2 cameras (models, prefabs) and some camera features. Most of the selected camera features are available in Unity using Volume Profiles. The sharpness and Lens Distortion Correction was implemented using Compute Shaders. More details can be found in the report here

Am I correct that CameraSensorFeatureManager is a class that sets HDAddtionalCameraData and Volume/VolumeProfile from a script?
Is there a problem with setting HDAddtionalCameraData and Volume/VolumeProfile without CameraSensorFeatureManager?

Yes, CameraSensorFeatureManager is a class that sets the volume or camera parameters. Basically, there is no problem setting the volume or camera parameters manually without the CameraSensorFeatureManager script. However, the CameraSensorFeatureManager is designed for ease of use. It acts as an interface for the user to enable/disable and control the camera effects.
The problem with controlling camera effects without the CameraSensorFeatureManager is that some effects are accessed in the volume object, while others are accessed in the camera object. There are also effects, such as motion blur, that require the camera object to be enabled. The intention of this CameraSensorFeatureManager is to handle all this for the user.

What are your thoughts on integrating the CameraSensorFeatureManager and CameraSensor classes?

This is a question of design. We decided to have two separate scripts. But there is nothing stopping us from merging the CameraSensorFeatureManager into CameraSensor. The question is if all camera sensors will have the image effects implemented? Also, CameraSensor already does a lot, so adding additional functionality might make CameraSensor less readable.

Can you please add documentation on the C1, C2 camera or this camera implementation?

Yes, we can add documentation. Can we merge this PR first and add the documentation in a separate PR?

[mackierx111]

Thanks for the implementation. I have added a few comments on my end. LGTM!