fix(agnocastlib): fix google-readability-casting (#302)

Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
tier4 · Nov 26, 2024 · 3fb87bc · 3fb87bc
1 parent 012c37e
commit 3fb87bc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -24,7 +24,6 @@ Checks: "
   -cppcoreguidelines-special-member-functions,
 
   google-*,
-  -google-readability-casting,
   -google-default-arguments,
   -google-build-using-namespace,
 

diff --git a/src/agnocastlib/src/agnocast_executor.cpp b/src/agnocastlib/src/agnocast_executor.cpp
@@ -128,7 +128,8 @@ bool AgnocastExecutor::get_next_agnocast_executables(
     exit(EXIT_FAILURE);
   }
 
-  for (int32_t i = (int32_t)receive_args.ret_len - 1; i >= 0; i--) {  // older messages first
+  for (int32_t i = static_cast<int32_t>(receive_args.ret_len) - 1; i >= 0;
+       i--) {  // older messages first
     const auto callable = agnocast::create_callable(
       reinterpret_cast<void *>(receive_args.ret_last_msg_addrs[i]),
       receive_args.ret_publisher_pids[i], receive_args.ret_timestamps[i], topic_local_id);

diff --git a/src/agnocastlib/src/agnocast_subscription.cpp b/src/agnocastlib/src/agnocast_subscription.cpp
@@ -88,7 +88,7 @@ union ioctl_subscriber_args SubscriptionBase::initialize(bool is_take_sub)
   }
 
   for (uint32_t i = 0; i < subscriber_args.ret_publisher_num; i++) {
-    if ((pid_t)subscriber_args.ret_pids[i] == subscriber_pid_) {
+    if (static_cast<pid_t>(subscriber_args.ret_pids[i]) == subscriber_pid_) {
       /*
        * NOTE: In ROS2, communication should work fine even if the same process exists as both a
        * publisher and a subscriber for a given topic. However, in Agnocast, to avoid applying