-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(heaphook_rust): add aligned alloc #226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
atsushi421
reviewed
Oct 7, 2024
Koichi98
reviewed
Oct 7, 2024
@veqcc |
@atsushi421 |
この件、posix_memalign()とPosixMemalignTypeの第一引数の型を&mut *mut c_voidにすれば解決しそうなんですが、それでちゃんとposix_memalignをフックできるか確認していないのでそちらお願いできると助かります!(もしすでに試されてたらすみません) |
atsushi421
previously approved these changes
Oct 7, 2024
veqcc
commented
Oct 7, 2024
Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
Koichi98
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
heaphook_rust に、alignment に関する命令3つ(posix_memalign, aligned_alloc, memalign)を追加しました。
それに伴い、free と realloc の処理も alignment に対応したものに修正しました。
Related links
How was this PR tested?
Autoware の pointcloud container が動作することを確認。具体的には、プロセスが死なずに Lsim tutorial で ego が最後まで走ることを確認した。
設定 pointcloud_container.launch.py
Notes for reviewers
以下の部分がどうしても clippy の警告を回避できず、
#[allow(clippy::not_unsafe_ptr_arg_deref)]
によって無理やり回避しています。代替案があれば。