From 9ae26639d603b60cfdbf2e9f29401d826fe06f95 Mon Sep 17 00:00:00 2001 From: veqcc Date: Tue, 26 Nov 2024 15:16:56 +0900 Subject: [PATCH] fix(agnocastlib): fix google-readability-casting Signed-off-by: veqcc --- .clang-tidy | 1 - src/agnocastlib/src/agnocast_executor.cpp | 3 ++- src/agnocastlib/src/agnocast_subscription.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 20c7e91a..2c7285bc 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -24,7 +24,6 @@ Checks: " -cppcoreguidelines-special-member-functions, google-*, - -google-readability-casting, -google-default-arguments, -google-build-using-namespace, diff --git a/src/agnocastlib/src/agnocast_executor.cpp b/src/agnocastlib/src/agnocast_executor.cpp index 5b0034fa..b221c6dd 100644 --- a/src/agnocastlib/src/agnocast_executor.cpp +++ b/src/agnocastlib/src/agnocast_executor.cpp @@ -128,7 +128,8 @@ bool AgnocastExecutor::get_next_agnocast_executables( exit(EXIT_FAILURE); } - for (int32_t i = (int32_t)receive_args.ret_len - 1; i >= 0; i--) { // older messages first + for (int32_t i = static_cast(receive_args.ret_len) - 1; i >= 0; + i--) { // older messages first const auto callable = agnocast::create_callable( reinterpret_cast(receive_args.ret_last_msg_addrs[i]), receive_args.ret_publisher_pids[i], receive_args.ret_timestamps[i], topic_local_id); diff --git a/src/agnocastlib/src/agnocast_subscription.cpp b/src/agnocastlib/src/agnocast_subscription.cpp index 588c283c..8b549260 100644 --- a/src/agnocastlib/src/agnocast_subscription.cpp +++ b/src/agnocastlib/src/agnocast_subscription.cpp @@ -88,7 +88,7 @@ union ioctl_subscriber_args SubscriptionBase::initialize(bool is_take_sub) } for (uint32_t i = 0; i < subscriber_args.ret_publisher_num; i++) { - if ((pid_t)subscriber_args.ret_pids[i] == subscriber_pid_) { + if (static_cast(subscriber_args.ret_pids[i]) == subscriber_pid_) { /* * NOTE: In ROS2, communication should work fine even if the same process exists as both a * publisher and a subscriber for a given topic. However, in Agnocast, to avoid applying