-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable co-operation with LD_PRELOAD apps #308
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: atsushi421 <atsushi.yano.2@tier4.jp>
veqcc
reviewed
Nov 29, 2024
Koichi98
reviewed
Nov 29, 2024
Koichi98
reviewed
Nov 29, 2024
Co-authored-by: Koichi Imai <45482193+Koichi98@users.noreply.github.com>
Co-authored-by: Koichi Imai <45482193+Koichi98@users.noreply.github.com>
何か他の共有ライブラリ (自作でテキトーな関数を引っ掛けるなど) を、sample appにLD_PRELOADに指定してもちゃんと動くかもテストしてみてください! |
veqcc
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ですが、これマージすると全レポジトリ・ブランチの LD_PRELOAD を変える必要があるので、すぐにマージするのではなく、全て同時マージでお願いしたいです。XX1 の方も。
This was referenced Dec 2, 2024
|
全てマージしました! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LD_PRELOAD
を使用するアプリケーションとの併用を可能にしました。詳細はドキュメントを見てください。Related links
How was this PR tested?
Notes for reviewers