Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add maybe_unused #324

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix: add maybe_unused #324

merged 1 commit into from
Jan 8, 2025

Conversation

atsushi421
Copy link
Contributor

@atsushi421 atsushi421 commented Jan 8, 2025

Description

agnocast適用Autowareで error: unused parameter ‘node’ [-Werror=unused-parameter] のエラーが出ないように修正しました。

Related links

https://star4.slack.com/archives/C07FL8616EM/p1736316546129739

How was this PR tested?

  • sample application (required)
  • Autoware (required) -> ビルドエラーが出ないことを確認

Notes for reviewers

Signed-off-by: atsushi421 <atsushi.yano.2@tier4.jp>
@atsushi421 atsushi421 requested a review from veqcc January 8, 2025 07:24
@atsushi421 atsushi421 added the run-build-test Run build-test in CI label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

------------------------------------------------------------------------------
                           GCC Code Coverage Report
Directory: .
------------------------------------------------------------------------------
File                                       Lines    Exec  Cover   Missing
------------------------------------------------------------------------------
src/agnocastlib/include/agnocast.hpp           2       2   100%   
src/agnocastlib/include/agnocast_executor.hpp
                                               1       0     0%   38
src/agnocastlib/include/agnocast_publisher.hpp
                                              24      19    79%   70-71,80-82
src/agnocastlib/include/agnocast_smart_pointer.hpp
                                              53      50    94%   77,80-81
src/agnocastlib/include/agnocast_topic_info.hpp
                                              13      13   100%   
src/agnocastlib/src/agnocast.cpp              82      15    18%   22,24,27,30,32-34,36,39,42,44-50,54-55,58-62,66-67,71-74,77,80,82-85,88,91,93-94,96-97,102,104-106,109-112,115,117-123,125,138-139,150-151,154-156,161
src/agnocastlib/src/agnocast_component_container.cpp
                                              12       0     0%   5,7-8,11-13,16,18-20,22-23
src/agnocastlib/src/agnocast_component_container_mt.cpp
                                              28       0     0%   7,11-12,14-16,18-20,22-24,26-28,30,32-33,35-37,40,42,44-46,48-49
src/agnocastlib/src/agnocast_executor.cpp
                                              86       0     0%   10,12,14-16,18-20,24,26,29,31-32,35-39,42-45,47-48,51-53,55-58,61-62,67,70,73,75-79,82,86-87,90-91,94,96-100,103,106,110-115,118,121-124,126-129,132,135-137,140,142,145,149-150,153-156,159,162,164-165
src/agnocastlib/src/agnocast_multi_threaded_executor.cpp
                                              51       0     0%   9,13,15-17,19-20,25-26,29-33,36,38-41,44,48,51,53-55,58-60,64,66-67,71,74,77,79-80,82-83,87-88,91,96,100,103-104,107,114-117,120
src/agnocastlib/src/agnocast_publisher.cpp
                                              73       0     0%   5,7,9-15,19-20,27,32,34-39,42-49,54,58-65,68-69,71-74,76-79,81,84-85,89-90,96,100-109,112-113,116,119,121-126,129
src/agnocastlib/src/agnocast_single_threaded_executor.cpp
                                              19       0     0%   10-12,16,18-21,24,28-30,33,35-37,40-42
src/agnocastlib/src/agnocast_smart_pointer.cpp
                                              20       0     0%   5,7-15,19,21-29
src/agnocastlib/src/agnocast_subscription.cpp
                                              90       9    10%   10-12,14,17,21,24-26,28,30,32,34-39,41-46,48,51-58,61-64,66,68,71,74,78-81,83-89,92-93,100,105,107-110,113,116,120-125,127-132,134,136,139,143-144,146-147
src/agnocastlib/src/agnocast_topic_info.cpp
                                              16       0     0%   12,16-17,20-24,28-31,34-37
src/agnocastlib/src/agnocast_utils.cpp        25      23    92%   48,50
------------------------------------------------------------------------------
TOTAL                                        595     131    22%
------------------------------------------------------------------------------

@atsushi421 atsushi421 merged commit d168345 into main Jan 8, 2025
5 checks passed
@atsushi421 atsushi421 deleted the fix_unused branch January 8, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-build-test Run build-test in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants